Skip to content

fix(morse): resolve same-hand HRM tap on press in Normal mode#842

Merged
HaoboGu merged 1 commit into
HaoboGu:mainfrom
jpds:fix/normal-mode-same-hand-roll-order
May 11, 2026
Merged

fix(morse): resolve same-hand HRM tap on press in Normal mode#842
HaoboGu merged 1 commit into
HaoboGu:mainfrom
jpds:fix/normal-mode-same-hand-roll-order

Conversation

@jpds
Copy link
Copy Markdown
Contributor

@jpds jpds commented May 10, 2026

I noticed that when I very quickly rolled a home-row key with another key fast (such as: a+g), what I would get would be "ga" as output.

That patch solves that issue by ensuring the taps fire in the correct order.

@jpds jpds force-pushed the fix/normal-mode-same-hand-roll-order branch from d1c9225 to 6623aff Compare May 10, 2026 18:11
@jpds
fix(morse): resolve same-hand HRM tap on press in Normal mode
63882cd 
In Normal mode with unilateral_tap enabled, a same-hand key pressed
while an HRM was held would fire immediately (no buffering), causing
the roll to come out in the wrong order. The unilateral tap only
fired on key release, by which point the plain key had already been
reported first.

Fix by checking unilateral_tap + same-hand on press in the Normal
mode arm of make_decisions_for_keys, triggering UnilateralTap for
the held HRM immediately and setting CleanBuffer so the incoming key
fires after.

Add test: test_normal_mode_same_hand_roll_order.
@jpds jpds force-pushed the fix/normal-mode-same-hand-roll-order branch from 6623aff to 63882cd Compare May 10, 2026 18:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2026

Size Report

Example main PR Diff .text .data .bss
use_config/nrf52832_ble 356.2 KiB 356.3 KiB +0.03% ⬆️ +144 0 0
use_config/nrf52840_ble 406.3 KiB 406.5 KiB +0.03% ⬆️ +140 0 0
use_config/nrf52840_ble_split (central) 482.2 KiB 482.3 KiB +0.02% ⬆️ +132 0 0
use_config/nrf52840_ble_split (peripheral) 307.2 KiB 307.2 KiB +0.00% 0 0 0
use_config/pi_pico_w_ble 640.2 KiB 640.3 KiB +0.01% ⬆️ +88 0 0
use_config/rp2040 146.7 KiB 146.7 KiB +0.05% ⬆️ +80 0 0
use_config/rp2040_split (central) 158.4 KiB 158.4 KiB +0.05% ⬆️ +88 0 0
use_config/rp2040_split (peripheral) 25.9 KiB 25.9 KiB -0.01% ⬇️ -4 0 0
use_config/stm32f1 62.3 KiB 62.4 KiB +0.19% ⬆️ +124 0 0
use_config/stm32h7 99.7 KiB 99.8 KiB +0.09% ⬆️ +100 0 0
use_rust/nrf52832_ble 345.3 KiB 345.4 KiB +0.03% ⬆️ +108 0 0
use_rust/nrf52840_ble 401.6 KiB 401.7 KiB +0.03% ⬆️ +144 0 0
use_rust/nrf52840_ble_split (central) 490.5 KiB 490.7 KiB +0.02% ⬆️ +148 0 0
use_rust/nrf52840_ble_split (peripheral) 304.5 KiB 304.5 KiB +0.00% 0 0 0
use_rust/pi_pico_w_ble 640.7 KiB 640.9 KiB +0.01% ⬆️ +116 0 0
use_rust/rp2040 146.4 KiB 146.5 KiB +0.05% ⬆️ +84 0 0
use_rust/rp2040_split (central) 157.7 KiB 157.7 KiB +0.05% ⬆️ +84 0 0
use_rust/rp2040_split (peripheral) 26.4 KiB 26.4 KiB +0.00% 0 0 0
use_rust/stm32f1 61.8 KiB 61.9 KiB +0.18% ⬆️ +116 0 0
use_rust/stm32h7 120.8 KiB 121.0 KiB +0.08% ⬆️ +108 0 0
use_config/nrf52832_ble — 356.2 KiB → 356.3 KiB (+0.03% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 326204	   5192	  33464	 364860	  5913c	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 326060	   5192	  33464	 364716	  590ac	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +391  [ = ]       0    .strtab
  +0.0%    +261  [ = ]       0    .debug_loc
  +0.2%    +176  [ = ]       0    .symtab
  +0.0%    +144  +0.0%    +144    .text
  +0.2%     +96  [ = ]       0    .debug_frame
  +0.1%     +48  [ = ]       0    .debug_aranges
  +0.0%     +35  [ = ]       0    .debug_info
  +0.0%     +16  [ = ]       0    .debug_line
  -0.0%     -16  [ = ]       0    .debug_ranges
 -27.0%     -17  [ = ]       0    [Unmapped]
  -0.0%    -370  [ = ]       0    .debug_str
  +0.0%    +764  +0.0%    +144    TOTAL
use_config/nrf52840_ble — 406.3 KiB → 406.5 KiB (+0.03% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 360764	   5200	  50248	 416212	  659d4	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 360624	   5200	  50248	 416072	  65948	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.74Ki  [ = ]       0    .debug_info
  +0.2% +1.29Ki  [ = ]       0    .debug_loc
  +0.0%    +885  [ = ]       0    .debug_str
  +0.1%    +397  [ = ]       0    .debug_line
  +0.1%    +353  [ = ]       0    .strtab
  +0.0%    +140  +0.0%    +140    .text
  +0.1%    +112  [ = ]       0    .symtab
  +0.1%     +60  [ = ]       0    .debug_frame
  +0.1%     +32  [ = ]       0    .debug_aranges
   +38%     +18  [ = ]       0    [Unmapped]
  +0.9%      +8  [ = ]       0    .defmt
  -0.0%     -56  [ = ]       0    .debug_ranges
  +0.1% +5.93Ki  +0.0%    +140    TOTAL
use_config/nrf52840_ble_split (central) — 482.2 KiB → 482.3 KiB (+0.02% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 441312	   6524	  46056	 493892	  78944	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 441180	   6524	  46056	 493760	  788c0	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.73Ki  [ = ]       0    .debug_info
  +0.2% +1.33Ki  [ = ]       0    .debug_loc
  +0.0%    +893  [ = ]       0    .debug_str
  +0.1%    +356  [ = ]       0    .strtab
  +0.1%    +225  [ = ]       0    .debug_line
  +0.0%    +132  +0.0%    +132    .text
  +0.1%    +112  [ = ]       0    .symtab
  +0.1%     +60  [ = ]       0    .debug_frame
  +0.1%     +32  [ = ]       0    .debug_aranges
  -8.6%      -5  [ = ]       0    [Unmapped]
  -0.0%     -56  [ = ]       0    .debug_ranges
  +0.1% +5.77Ki  +0.0%    +132    TOTAL
use_config/nrf52840_ble_split (peripheral) — 307.2 KiB → 307.2 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 282128	   5888	  26520	 314536	  4cca8	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 282128	   5888	  26520	 314536	  4cca8	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +9  [ = ]       0    .debug_loc
  +0.0%      +8  [ = ]       0    .debug_aranges
  +8.1%      +5  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .debug_line
  -0.0%      -9  [ = ]       0    .strtab
  -0.0%    -192  [ = ]       0    .debug_str
  -0.0%    -207  [ = ]       0    .debug_info
  -0.0%    -388  [ = ]       0    TOTAL
use_config/pi_pico_w_ble — 640.2 KiB → 640.3 KiB (+0.01% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 601028	      0	  54632	 655660	  a012c	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 600940	      0	  54632	 655572	  a00d4	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +1.52Ki  [ = ]       0    .debug_str
  +0.1%    +325  [ = ]       0    .strtab
  +0.1%     +96  [ = ]       0    .symtab
  +0.0%     +88  +0.0%     +88    .text
  +0.1%     +32  [ = ]       0    .debug_frame
  +0.0%     +16  [ = ]       0    .debug_aranges
  -0.0%     -16  [ = ]       0    .debug_ranges
  -0.0%     -26  [ = ]       0    .debug_loc
 -40.0%     -28  [ = ]       0    [Unmapped]
  -0.1%    -225  [ = ]       0    .debug_line
  -0.0%    -499  [ = ]       0    .debug_info
  +0.0% +1.29Ki  +0.0%     +88    TOTAL
use_config/rp2040 — 146.7 KiB → 146.7 KiB (+0.05% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 135012	      0	  15244	 150256	  24af0	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 134932	      0	  15244	 150176	  24aa0	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3%    +324  [ = ]       0    .strtab
  +0.0%    +271  [ = ]       0    .debug_info
  +0.0%    +177  [ = ]       0    .debug_str
  +0.3%     +96  [ = ]       0    .symtab
  +0.1%     +80  +0.1%     +80    .text
  +0.2%     +32  [ = ]       0    .debug_frame
  +0.1%     +16  [ = ]       0    .debug_aranges
  -0.0%      -6  [ = ]       0    .debug_line
 -23.8%     -15  [ = ]       0    [Unmapped]
  -0.0%     -16  [ = ]       0    .debug_ranges
  -0.0%     -55  [ = ]       0    .debug_loc
  +0.0%    +904  +0.1%     +80    TOTAL
use_config/rp2040_split (central) — 158.4 KiB → 158.4 KiB (+0.05% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 146240	      0	  16008	 162248	  279c8	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 146152	      0	  16008	 162160	  27970	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +651  [ = ]       0    .debug_str
  +0.3%    +324  [ = ]       0    .strtab
  +0.0%    +251  [ = ]       0    .debug_info
  +0.3%     +96  [ = ]       0    .symtab
  +0.1%     +88  +0.1%     +88    .text
  +0.2%     +32  [ = ]       0    .debug_frame
  +0.1%     +16  [ = ]       0    .debug_aranges
   +23%     +10  [ = ]       0    [Unmapped]
  -0.0%      -3  [ = ]       0    .debug_loc
  -0.0%      -9  [ = ]       0    .debug_line
  -0.0%     -16  [ = ]       0    .debug_ranges
  +0.0% +1.41Ki  +0.1%     +88    TOTAL
use_config/rp2040_split (peripheral) — 25.9 KiB → 25.9 KiB (-0.01% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  24016	     56	   2412	  26484	   6774	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  24020	     56	   2412	  26488	   6778	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +206  [ = ]       0    .debug_str
  +0.0%     +24  [ = ]       0    .debug_info
  +0.1%      +8  [ = ]       0    .debug_aranges
   +24%      +8  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .strtab
  -0.1%      -4  -0.1%      -4    .rodata
  +0.0%    +240  -0.0%      -4    TOTAL
use_config/stm32f1 — 62.3 KiB → 62.4 KiB (+0.19% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  56432	     28	   7432	  63892	   f994	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  56308	     28	   7432	  63768	   f918	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%    +231  [ = ]       0    .debug_loc
  +0.7%    +216  [ = ]       0    .strtab
  +0.8%    +160  [ = ]       0    .symtab
  +0.2%    +124  +0.2%    +124    .text
  +0.8%     +96  [ = ]       0    .debug_frame
  +0.6%     +40  [ = ]       0    .debug_aranges
  +0.1%     +24  [ = ]       0    .debug_ranges
  +0.2%     +14  [ = ]       0    .debug_abbrev
  +3.1%      +2  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .debug_info
  -0.0%      -2  [ = ]       0    .debug_line
  -0.0%    -143  [ = ]       0    .debug_str
  +0.0%    +760  +0.2%    +124    TOTAL
use_config/stm32h7 — 99.7 KiB → 99.8 KiB (+0.09% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  92220	    268	   9664	 102152	  18f08	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  92120	    268	   9664	 102052	  18ea4	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +579  [ = ]       0    .debug_info
  +0.4%    +216  [ = ]       0    .strtab
  +0.1%    +208  [ = ]       0    .debug_loc
  +0.6%    +160  [ = ]       0    .symtab
  +0.1%    +100  +0.1%    +100    .text
  +0.6%     +96  [ = ]       0    .debug_frame
  +0.1%     +40  [ = ]       0    .debug_aranges
  +0.0%     +24  [ = ]       0    .debug_ranges
 -13.0%      -6  [ = ]       0    [Unmapped]
  -0.0%     -81  [ = ]       0    .debug_str
  -0.1%    -160  [ = ]       0    .debug_line
  +0.0% +1.15Ki  +0.1%    +100    TOTAL
use_rust/nrf52832_ble — 345.3 KiB → 345.4 KiB (+0.03% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 316052	   5200	  32456	 353708	  565ac	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 315944	   5200	  32456	 353600	  56540	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +214  [ = ]       0    .strtab
  +0.0%    +208  [ = ]       0    .debug_loc
  +0.0%    +203  [ = ]       0    .debug_info
  +0.2%    +160  [ = ]       0    .symtab
  +0.0%    +108  +0.0%    +108    .text
  +0.2%     +96  [ = ]       0    .debug_frame
  +0.9%     +70  [ = ]       0    .debug_abbrev
  +0.1%     +40  [ = ]       0    .debug_aranges
  +0.0%     +24  [ = ]       0    .debug_ranges
 -22.4%     -13  [ = ]       0    [Unmapped]
  -0.0%     -47  [ = ]       0    .debug_line
  -0.0%    -979  [ = ]       0    .debug_str
  +0.0%     +84  +0.0%    +108    TOTAL
use_rust/nrf52840_ble — 401.6 KiB → 401.7 KiB (+0.03% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 360404	   5200	  45728	 411332	  646c4	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 360260	   5200	  45728	 411188	  64634	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +419  [ = ]       0    .strtab
  +0.0%    +271  [ = ]       0    .debug_loc
  +0.1%    +176  [ = ]       0    .symtab
  +0.0%    +166  [ = ]       0    .debug_info
  +0.0%    +144  +0.0%    +144    .text
  +0.2%     +96  [ = ]       0    .debug_frame
  +0.1%     +48  [ = ]       0    .debug_aranges
  -0.0%     -16  [ = ]       0    .debug_ranges
 -26.7%     -16  [ = ]       0    [Unmapped]
  -0.0%     -29  [ = ]       0    .debug_line
  -0.0%    -203  [ = ]       0    .debug_str
  +0.0% +1.03Ki  +0.0%    +144    TOTAL
use_rust/nrf52840_ble_split (central) — 490.5 KiB → 490.7 KiB (+0.02% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 444132	   6524	  51792	 502448	  7aab0	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 443984	   6524	  51792	 502300	  7aa1c	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +3.25Ki  [ = ]       0    .debug_info
  +0.2% +1.30Ki  [ = ]       0    .debug_loc
  +0.0%    +849  [ = ]       0    .debug_str
  +0.1%    +381  [ = ]       0    .strtab
  +0.1%    +260  [ = ]       0    .debug_line
  +0.0%    +148  +0.0%    +148    .text
  +0.1%    +144  [ = ]       0    .symtab
  +0.1%     +76  [ = ]       0    .debug_frame
  +0.1%     +40  [ = ]       0    .debug_aranges
  +0.9%      +8  [ = ]       0    .defmt
 -28.8%     -19  [ = ]       0    [Unmapped]
  -0.0%     -48  [ = ]       0    .debug_ranges
  +0.1% +6.34Ki  +0.0%    +148    TOTAL
use_rust/nrf52840_ble_split (peripheral) — 304.5 KiB → 304.5 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 281148	   5328	  25288	 311764	  4c1d4	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 281148	   5328	  25288	 311764	  4c1d4	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +49  [ = ]       0    .debug_str
  +0.0%     +36  [ = ]       0    .debug_info
  +0.0%      +9  [ = ]       0    .debug_loc
  +0.0%      +8  [ = ]       0    .debug_aranges
  -2.9%      -2  [ = ]       0    [Unmapped]
  -0.0%      -8  [ = ]       0    .strtab
  +0.0%     +92  [ = ]       0    TOTAL
use_rust/pi_pico_w_ble — 640.7 KiB → 640.9 KiB (+0.01% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 601464	      0	  54776	 656240	  a0370	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 601348	      0	  54776	 656124	  a02fc	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.08Ki  [ = ]       0    .debug_str
  +0.2%    +475  [ = ]       0    .strtab
  +0.0%    +155  [ = ]       0    .debug_loc
  +0.2%    +128  [ = ]       0    .symtab
  +0.0%    +116  +0.0%    +116    .text
  +0.2%     +60  [ = ]       0    .debug_frame
  +0.1%     +24  [ = ]       0    .debug_aranges
   +31%     +14  [ = ]       0    [Unmapped]
  -0.0%      -8  [ = ]       0    .debug_ranges
  -0.1%     -14  [ = ]       0    .debug_abbrev
  -0.0%     -31  [ = ]       0    .debug_line
  -0.0%    -228  [ = ]       0    .debug_info
  +0.0% +2.75Ki  +0.0%    +116    TOTAL
use_rust/rp2040 — 146.4 KiB → 146.5 KiB (+0.05% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 134884	      0	  15124	 150008	  249f8	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 134800	      0	  15124	 149924	  249a4	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +497  [ = ]       0    .debug_info
  +0.3%    +324  [ = ]       0    .strtab
  +0.3%     +96  [ = ]       0    .symtab
  +0.1%     +84  +0.1%     +84    .text
  +0.0%     +34  [ = ]       0    .debug_str
  +0.2%     +32  [ = ]       0    .debug_frame
  +0.1%     +16  [ = ]       0    .debug_aranges
  +0.0%     +13  [ = ]       0    .debug_line
  -0.0%     -16  [ = ]       0    .debug_ranges
 -28.8%     -19  [ = ]       0    [Unmapped]
  -0.0%     -25  [ = ]       0    .debug_loc
  +0.0% +1.01Ki  +0.1%     +84    TOTAL
use_rust/rp2040_split (central) — 157.7 KiB → 157.7 KiB (+0.05% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 145740	      0	  15788	 161528	  276f8	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 145656	      0	  15788	 161444	  276a4	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +866  [ = ]       0    .debug_str
  +0.1%    +562  [ = ]       0    .debug_info
  +0.3%    +324  [ = ]       0    .strtab
  +0.1%    +121  [ = ]       0    .debug_line
  +0.3%     +96  [ = ]       0    .symtab
  +0.1%     +84  +0.1%     +84    .text
  +0.2%     +32  [ = ]       0    .debug_frame
  +0.1%     +16  [ = ]       0    .debug_aranges
  +0.0%      +7  [ = ]       0    .debug_loc
  -0.0%     -16  [ = ]       0    .debug_ranges
 -35.7%     -20  [ = ]       0    [Unmapped]
  +0.1% +2.02Ki  +0.1%     +84    TOTAL
use_rust/rp2040_split (peripheral) — 26.4 KiB → 26.4 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  24316	     56	   2676	  27048	   69a8	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  24316	     56	   2676	  27048	   69a8	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +210  [ = ]       0    .debug_str
  +0.0%     +24  [ = ]       0    .debug_info
  +0.1%      +8  [ = ]       0    .debug_aranges
  +6.8%      +4  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .strtab
  +0.0%    +244  [ = ]       0    TOTAL
use_rust/stm32f1 — 61.8 KiB → 61.9 KiB (+0.18% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  55968	     28	   7408	  63404	   f7ac	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  55852	     28	   7408	  63288	   f738	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%    +231  [ = ]       0    .debug_loc
  +0.7%    +216  [ = ]       0    .strtab
  +0.0%    +185  [ = ]       0    .debug_str
  +0.8%    +160  [ = ]       0    .symtab
  +0.0%    +119  [ = ]       0    .debug_info
  +0.2%    +116  +0.2%    +116    .text
  +0.8%     +96  [ = ]       0    .debug_frame
  +0.9%     +40  [ = ]       0    .debug_aranges
  +0.0%     +28  [ = ]       0    .debug_line
  +0.1%     +24  [ = ]       0    .debug_ranges
  +0.2%     +14  [ = ]       0    .debug_abbrev
   +26%     +11  [ = ]       0    [Unmapped]
  +0.1% +1.21Ki  +0.2%    +116    TOTAL
use_rust/stm32h7 — 120.8 KiB → 121.0 KiB (+0.08% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 108080	    324	  15452	 123856	  1e3d0	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 107972	    324	  15452	 123748	  1e364	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +271  [ = ]       0    .debug_info
  +0.3%    +221  [ = ]       0    .strtab
  +0.1%    +220  [ = ]       0    .debug_loc
  +0.4%    +160  [ = ]       0    .symtab
  +0.1%    +108  +0.1%    +108    .text
  +0.5%     +96  [ = ]       0    .debug_frame
  +0.1%     +40  [ = ]       0    .debug_aranges
   +70%     +26  [ = ]       0    [Unmapped]
  +0.0%     +24  [ = ]       0    .debug_ranges
  -0.0%      -5  [ = ]       0    .debug_line
  -0.0%    -453  [ = ]       0    .debug_str
  +0.0%    +708  +0.1%    +108    TOTAL

@HaoboGu
Copy link
Copy Markdown
Owner

HaoboGu commented May 11, 2026

lgtm, thanks!

@HaoboGu HaoboGu merged commit f98149f into HaoboGu:main May 11, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpds @HaoboGu