Skip to content
This repository was archived by the owner on Jun 1, 2024. It is now read-only.

Conversation

edonaHajredinaj
Copy link

Adds Feature Request 2985, Added a custom username editor so that users can hide their username if someone looks at their phone screen.

@TacoTheDank
Copy link
Member

@edonaHajredinaj Just a few nitpicks I have: please make openDialog private and rename it to fakenameDialog, and also replace .equals("") with .isEmpty(). Other than that, it looks good. Thank you very much for your contribution! :)

@TacoTheDank TacoTheDank linked an issue Dec 13, 2020 that may be closed by this pull request
@TacoTheDank
Copy link
Member

@edonaHajredinaj Any updates?

@TacoTheDank
Copy link
Member

Guess I'll do it myself then...

@edonaHajredinaj

This comment has been minimized.

@TacoTheDank
Copy link
Member

@edonaHajredinaj No worries, I've already done it :)

Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just some R.string.* changes needed (allows them to be translated into different languages)

@ccrama
Copy link
Collaborator

ccrama commented Jan 19, 2021

I've updated the string resources, we should use the AlertDialogWrapper for better theming of this popup

This was referenced Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Username Hider/Replacer

4 participants