Fix Switch support#175
Merged
Merged
Conversation
Switch::Init(PostInit) was called multiple times, causing multiple applet hooks (that all point to the same callback address) to be registered. For some reason, the OS started spamming us with FocusUpdate events via that hook because of that.
…ches caused by undefined behavior
# Conflicts: # .github/workflows/main.yml # .github/workflows/switch.yml # CMakeLists.txt # src/port/Engine.cpp # src/port/GameExtractor.cpp
Contributor
Author
|
Newer test build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on pull request #169 to be merged first. I'll rebase this PR when that one is merged.This fixes the broken Switch implementation and restores the CI build scripts for the platform.
Scripting is disabled due to missing platform support for tcc.
Needs the
Net64DD/libultraship@main-nx-nightlybranch to be checked out before compiling.Test build:Ghostship-switch.zip
Also, initially I ran into a weird glitch that would lock the camera somewhere out of bounds, even on the title screen. After some troubleshooting that I found out that setting the
-O2or-O3compiler optimization levels in theCFLAGScauses this issue. It looks like there's undefined behavior somewhere in the C code. I was able to narrow the cause down to the-fstrict-aliasingoptimization and disabled it.(It's also reproducible on the PC build, but it didn't manifest there because it used
-O1by default while the Switch build used-O3).