Skip to content

Fix special characters in path #126 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KiritoDv merged 1 commit into from
May 30, 2026
Merged

Fix special characters in path #126 #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/port/GameExtractor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ std::unordered_map<std::string, std::string> mGameList = {
{ "9bef1128717f958171a4afac3ed78ee2bb4e86ce", "Super Mario 64 (US)" },
};

static std::filesystem::path Utf8ToFsPath(const std::string& utf8) {
return std::filesystem::path(reinterpret_cast<const char8_t*>(utf8.c_str()));
}

bool GameExtractor::RunStandalone(std::string rom) {
// Store both path and already-read data
std::string romPath;
Expand Down Expand Up @@ -117,12 +121,13 @@ bool GameExtractor::SelectGameFromUI() {

// Load file if it is not already open
if (romData.empty()) {
if (!std::filesystem::exists(romPath)) {
const std::filesystem::path romFsPath = Utf8ToFsPath(romPath);
if (!std::filesystem::exists(romFsPath)) {
SPDLOG_ERROR("Failed to find ROM at path: {}", romPath);
return false;
}

std::ifstream inFile(romPath, std::ios::binary);
std::ifstream inFile(romFsPath, std::ios::binary);
if (!inFile.is_open()) {
return false;
}
Expand Down
Loading