Fix use-after-free crash in audio synthesis on level reset (#133)#197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sound_reset()runs on the game thread and synchronously callsaudio_reset_session()(reinitializes the audio heap / note pool) while the audio thread is mid-synthesis_process_notes -> final_resample -> aResampleImpl, reading freed sample memory.Added
GameEngine_LockAudioThread/Unlockbridges that take the sameaudio.mutexHandleAudioThreadholds during synthesis, and wrappedsound_reset()'s body with them. The reset now waits for any in-flight resample frame, and the next synthesis frame waits for the reset to finish.sound_resetis only ever called from the game thread, so there's no audio-thread re-entrancy / deadlock.Addresses #133