File Select More Info Update #5998
Open
+867
−695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Dec 1, 2025
Contributor
Malkierian
left a comment
Malkierian
left a comment
There was a problem hiding this comment.
Looks good, works perfectly from what I can tell. Has a new conflict, though.
serprex
reviewed
Dec 1, 2025
| // using 0xB0 and later as they're not real item ids | ||
| // TODO: improve this (RandomizerGet doesn't work) | ||
|
|
||
| // disabled due to lus issue |
Contributor
There was a problem hiding this comment.
please expand, ideally link to issue on lus issue tracker
Contributor
Author
There was a problem hiding this comment.
Haven't made an issue yet, but I mentioned it in the discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR massively improves the "File Select More Info" enhancement:
Build Artifacts