Skip to content

Feature/fix ci starter task 1 - #296

Draft
Ericliu-uz wants to merge 6 commits into
mainfrom
feature/fix-ci-starter-task-1
Draft

Feature/fix ci starter task 1#296
Ericliu-uz wants to merge 6 commits into
mainfrom
feature/fix-ci-starter-task-1

Conversation

@Ericliu-uz

Copy link
Copy Markdown

Summary

Resolves CI build and pipeline failure issues across tasks (a), (b) and (c) by fixing frontend TypeScript definitions, securing backend cookie settings, and removing an orphaned submodule gitlink.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor / code cleanup
  • Documentation
  • CI/CD / infrastructure
  • Security

Affected Components

  • /backend-api
  • /frontend
  • /engine (collectors / policies)
  • /security
  • /infrastructure
  • /.github/workflows
  • /docs

Motivation

Fixed CI starter tasks A, B, and C to restore main branch pipeline health and clear CodeQL security alerts.

Testing Done

  • Unit tests pass locally
  • Tested manually — describe how:
    • Verified TypeScript compilation locally after fixing onFormChange prop types in SignupFormPanel.tsx.
    • Confirmed authentication cookie security flags (httponly, secure=True, samesite="lax") in auth.py.
    • Ran git rm --cached to untrack the phantom rapidscan submodule from the Git index.
  • No tests required — explain why:

Security Considerations

Hardcoded explicit secure=True, httponly=True, and samesite="lax" parameters on authentication cookies in auth.py to fix the CodeQL py/insecure-cookie alert.

Breaking Changes

  • No breaking changes
  • Yes — describe below:

Rollback Plan

  • Revert commit is sufficient
  • Requires additional steps — describe below:

Checklist

  • Code follows project conventions
  • No secrets, credentials, or tokens committed
  • Relevant documentation updated (if applicable)
  • CI/CD workflows pass on this branch
  • PR is focused on one thing

@github-actions

Copy link
Copy Markdown
Contributor

Preview Environment

A preview environment can be spun up on demand for this PR.

Action Label Includes
Spin up preview deploy-preview Frontend, backend, database, Redis, OPA, worker
Spin up preview with M365 deploy-preview-m365 Everything above + PowerShell service for Exchange/Teams scan testing
Tear down preview teardown-preview Stops the environment early

The environment will also be torn down automatically when the PR is closed or merged.
Preview URLs will appear in a follow-up comment once the deploy completes (~5–8 min).
M365 scans require real tenant credentials added through the frontend UI.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

CI: Frontend

Job Result
Security analysis (CodeQL) success
Lint success
Build and test success

All checks passed.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

CI: Security

Job Result
Security analysis (CodeQL) success
Lint success

All checks passed.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

CI: Backend API

Job Result
Security analysis (CodeQL + Bandit) success
Lint success

All checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant