Feature/fix ci starter task 1 - #296
Draft
Ericliu-uz wants to merge 6 commits into
Draft
Conversation
Contributor
Preview EnvironmentA preview environment can be spun up on demand for this PR.
|
Contributor
CI: Frontend
All checks passed. |
Contributor
CI: Security
All checks passed. |
Contributor
CI: Backend API
All checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves CI build and pipeline failure issues across tasks (a), (b) and (c) by fixing frontend TypeScript definitions, securing backend cookie settings, and removing an orphaned submodule gitlink.
Type of Change
Affected Components
/backend-api/frontend/engine(collectors / policies)/security/infrastructure/.github/workflows/docsMotivation
Fixed CI starter tasks A, B, and C to restore main branch pipeline health and clear CodeQL security alerts.
Testing Done
onFormChangeprop types inSignupFormPanel.tsx.httponly,secure=True,samesite="lax") inauth.py.git rm --cachedto untrack the phantomrapidscansubmodule from the Git index.Security Considerations
Hardcoded explicit
secure=True,httponly=True, andsamesite="lax"parameters on authentication cookies inauth.pyto fix the CodeQLpy/insecure-cookiealert.Breaking Changes
Rollback Plan
Checklist