Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.8.15 #459

Merged
merged 6 commits into from
Feb 18, 2025
Merged

v4.8.15 #459

merged 6 commits into from
Feb 18, 2025

Conversation

BboyAkers
Copy link
Member

PR

Ticket

STUDIO-164

Overview

When clicking on folders in our application editor, folders will now collapse.

Manual Testing:

  1. Log in and navigate to /Applications
  2. Once the page loads click on a folder in the file browser sidebar.

Expected Result
User should be able to collapse and expand the contents of a folders' children when clicking the folder icon.

Additional Context

Looked into having it all collapse initially but that's a bit more tricky and will require more time to look into. This SHOULD be sufficient and allow our end users to be a bit more happier when navigating through the file browser sidebar.

Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory collapsing looks good. Can we apply this collapsing functionality to the application folder as well? That is, you should be able to click on the application "cube" and collapse the whole application directory. And starting with the application directory collapsed is probably the preferred state.

@BboyAkers
Copy link
Member Author

The directory collapsing looks good. Can we apply this collapsing functionality to the application folder as well? That is, you should be able to click on the application "cube" and collapse the whole application directory. And starting with the application directory collapsed is probably the preferred state.

Done!!!! 🙂

@BboyAkers BboyAkers requested a review from kriszyp February 12, 2025 18:55
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice work! we should get this over to RL asap. Make them even happier.

@kriszyp
Copy link
Member

kriszyp commented Feb 12, 2025

Looking great! A few issues:

  • I think the target for collapsing/expanding should be the whole folder name, not just the icon. When everything is collapsed and you click on the app and nothing shows or expands, I think that is confusing.
  • When you save any changes, everything collapses. I don't think we want to change the collapse/expand state when things are saved
  • I can't expand when I am connecting to some of our remote servers. Is it possible that maybe this can't be expanded for apps that are deployed by github reference (and are read-only)? Or maybe an issue with older server versions? Maybe @mihaiharperdb can investigate this?

@BboyAkers BboyAkers merged commit e3b447d into master Feb 18, 2025
3 checks passed
@mihaiharperdb
Copy link

@BboyAkers I agree with @kriszyp on:

  • the target for collapsing/expanding should be the whole folder name, not just the icon. When everything is collapsed and you click on the app name (text) and nothing shows or expands, I think that is confusing.

  • when you save any changes or add/delete a folder/file, all applications expand, although they were collapsed and I was working on only one expanded application

@kriszyp I deployed locally apps by github reference and I can expand/collapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants