prompt(issue-to-pr): :test should run format:check before push - #19
Merged
Conversation
Surfaced from harper #490 (a sinon/rewire OCSP unit test the agent opened via claude-fix:test). Format Check failed in CI because the agent didn't format-check before pushing — the previous :test validation block only said "lint + run the modified tests". The other label scopes (typo / docs / deps / bug) all include format:check; :test was the outlier. Adds `npm run format:check` to the :test validation step, plus explicit recovery: if format:check flags newly-added files, run `npm run format:write` and re-confirm with format:check. Caller pin bumps for harper / oauth / harper-pro will pick this up on the next routine sweep. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
heskew
added a commit
that referenced
this pull request
Jun 23, 2026
Addresses the two valid gemini consistency suggestions: link the #616/#615/#613 reprise in the noise-pattern list and the harper#1409 / #1386/#1209/#1410/#1314 refs in the Signal weighting line, matching the citation style used elsewhere in the entry. (Declined the third suggestion — dropping harper/common.md from the "No changes to" line — that line is accurate changelog metadata, not a live cross-layer reference.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous
:testdefaultpre-commit-validationblock said "lint + run the modified tests"; the other label scopes (typo / docs / deps / bug) all includeformat:check.:testwas the outlier. harper #490's first commit hit a Format Check failure because the agent didn't catch unformatted output before pushing.Fix: add
npm run format:checkto the:testvalidation step, plus explicit guidance: ifformat:checkflags newly-added files, runnpm run format:writeto fix and re-runformat:checkto confirm.Why this is its own PR
Split out from #18 so it can ship without the App-permission prereq that gates the App-token-push fix. This is a one-line prompt addition with no infrastructure dependency.
Test plan
yqparses the modified file cleanly.🤖 Generated with Claude Code