chore: migrate to @harperfast/code-guidelines - #629
Conversation
@harperdb/code-guidelines is deprecated and has been republished as @harperfast/code-guidelines; 0.1.1 is functionally identical to 0.0.6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the development dependency @harperdb/code-guidelines to @harperfast/code-guidelines (version ^0.1.1) in both package.json and package-lock.json, and updates the Prettier configuration path accordingly. Additionally, package-lock.json reflects minor metadata adjustments for several optional dependencies. There are no review comments, and I have no feedback to provide.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Reviewed; no blockers found. |
0.1.1 accidentally published .claude and docs directories; 0.1.2 adds a files allowlist to package.json to exclude them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kriszyp
left a comment
There was a problem hiding this comment.
code guidelines looks good. Again, package-lock.json.
🤖 Reviewed with GPT 5.6
| "libc": [ | ||
| "glibc" | ||
| ], | ||
| "license": "Apache-2.0", |
There was a problem hiding this comment.
Could you preserve the unrelated libc metadata while regenerating this lockfile? The selector was removed from all four RocksDB Linux packages (and the affected oxlint bindings). npm treats a missing libc field as compatible: on x64 glibc, Arborist now leaves both the glibc and musl RocksDB packages active, so installs download both ~5–6 MB native tarballs, and the published shrinkwrap retains the missing selectors. I reproduced the source of the churn with the repo's base lock: npm 11.5.1 strips this field, while npm 11.16.0 preserves it. Regenerating the rename from the base lock with the current supported Node/npm toolchain, or restoring the dropped libc fields, keeps each Linux install on its single matching binary.
The previous lock regeneration used npm 10, which drops the libc discriminator from platform-specific optional deps, causing npm ci on Linux to install both glibc and musl RocksDB bindings. Regenerated from main's lock with npm 11; the diff is now scoped to the code-guidelines subtree only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kriszyp
left a comment
There was a problem hiding this comment.
Looks good.
🤖 Reviewed with GPT 5.6
| "libc": [ | ||
| "glibc" | ||
| ], | ||
| "license": "Apache-2.0", |
There was a problem hiding this comment.
Could you preserve the unrelated libc metadata while regenerating this lockfile? The selector was removed from all four RocksDB Linux packages (and the affected oxlint bindings). npm treats a missing libc field as compatible: on x64 glibc, Arborist now leaves both the glibc and musl RocksDB packages active, so installs download both ~5–6 MB native tarballs, and the published shrinkwrap retains the missing selectors. I reproduced the source of the churn with the repo's base lock: npm 11.5.1 strips this field, while npm 11.16.0 preserves it. Regenerating the rename from the base lock with the current supported Node/npm toolchain, or restoring the dropped libc fields, keeps each Linux install on its single matching binary.
@harperdb/code-guidelineshas been deprecated and republished as@harperfast/code-guidelines. Version 0.1.2 is functionally identical to 0.0.6 — no config changes, just the new package name (0.1.2 also adds afilesallowlist so.claudeanddocsare no longer included in the published artifact).This updates the dependency, any config references (prettier/eslint/docs), and the lockfile. No new lockfiles were added.
sent with Claude Fable 5