Skip to content

chore: migrate to @harperfast/code-guidelines - #629

Merged
Ethan-Arrowood merged 3 commits into
mainfrom
chore/harperfast-code-guidelines
Jul 30, 2026
Merged

chore: migrate to @harperfast/code-guidelines#629
Ethan-Arrowood merged 3 commits into
mainfrom
chore/harperfast-code-guidelines

Conversation

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood commented Jul 29, 2026

Copy link
Copy Markdown
Member

@harperdb/code-guidelines has been deprecated and republished as @harperfast/code-guidelines. Version 0.1.2 is functionally identical to 0.0.6 — no config changes, just the new package name (0.1.2 also adds a files allowlist so .claude and docs are no longer included in the published artifact).

This updates the dependency, any config references (prettier/eslint/docs), and the lockfile. No new lockfiles were added.

sent with Claude Fable 5

@harperdb/code-guidelines is deprecated and has been republished as
@harperfast/code-guidelines; 0.1.1 is functionally identical to 0.0.6.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Ethan-Arrowood
Ethan-Arrowood requested a review from a team as a code owner July 29, 2026 13:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the development dependency @harperdb/code-guidelines to @harperfast/code-guidelines (version ^0.1.1) in both package.json and package-lock.json, and updates the Prettier configuration path accordingly. Additionally, package-lock.json reflects minor metadata adjustments for several optional dependencies. There are no review comments, and I have no feedback to provide.

@socket-security

socket-security Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​harperfast/​code-guidelines@​0.1.2701009993100

View full report

@claude

claude Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reviewed; no blockers found.

0.1.1 accidentally published .claude and docs directories; 0.1.2 adds
a files allowlist to package.json to exclude them.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@kriszyp kriszyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code guidelines looks good. Again, package-lock.json.

🤖 Reviewed with GPT 5.6

Comment thread package-lock.json
"libc": [
"glibc"
],
"license": "Apache-2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you preserve the unrelated libc metadata while regenerating this lockfile? The selector was removed from all four RocksDB Linux packages (and the affected oxlint bindings). npm treats a missing libc field as compatible: on x64 glibc, Arborist now leaves both the glibc and musl RocksDB packages active, so installs download both ~5–6 MB native tarballs, and the published shrinkwrap retains the missing selectors. I reproduced the source of the churn with the repo's base lock: npm 11.5.1 strips this field, while npm 11.16.0 preserves it. Regenerating the rename from the base lock with the current supported Node/npm toolchain, or restoring the dropped libc fields, keeps each Linux install on its single matching binary.

The previous lock regeneration used npm 10, which drops the libc
discriminator from platform-specific optional deps, causing npm ci on
Linux to install both glibc and musl RocksDB bindings. Regenerated
from main's lock with npm 11; the diff is now scoped to the
code-guidelines subtree only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@kriszyp kriszyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
🤖 Reviewed with GPT 5.6

Comment thread package-lock.json
"libc": [
"glibc"
],
"license": "Apache-2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you preserve the unrelated libc metadata while regenerating this lockfile? The selector was removed from all four RocksDB Linux packages (and the affected oxlint bindings). npm treats a missing libc field as compatible: on x64 glibc, Arborist now leaves both the glibc and musl RocksDB packages active, so installs download both ~5–6 MB native tarballs, and the published shrinkwrap retains the missing selectors. I reproduced the source of the churn with the repo's base lock: npm 11.5.1 strips this field, while npm 11.16.0 preserves it. Regenerating the rename from the base lock with the current supported Node/npm toolchain, or restoring the dropped libc fields, keeps each Linux install on its single matching binary.

@Ethan-Arrowood
Ethan-Arrowood merged commit 666ffa5 into main Jul 30, 2026
29 checks passed
@Ethan-Arrowood
Ethan-Arrowood deleted the chore/harperfast-code-guidelines branch July 30, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants