-
Notifications
You must be signed in to change notification settings - Fork 10
Eliminate TypeScript Errors and Convert foundational .js files to .ts #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
7b442e5
861be3d
7100c23
7fb4686
c0d043f
ca7ea69
38384a5
091f010
5a4add0
cb15a2e
22087ef
e1e685e
4fc0d70
7d52c92
b6411cc
08e71d8
4fe9eb0
a959e1a
4292fac
be10340
db86dd6
a590460
e1875db
2646aa3
ed60382
d9b9538
618d30d
4c1b1f7
8dacd0e
b1cb11e
b875428
a900330
5fbb450
54c6b02
71e97df
276ab1a
9708185
37b7a7e
f0035d8
82eedc6
9aa43fc
5e64361
20c2752
8818e7f
91f0ee3
f25506e
dc37d4a
c38cf85
3e7716d
e50d36c
fc0569d
331ddaf
600355d
fc0b2ff
cf3c8e3
683beaa
62145ed
e3518ac
d842414
e5f8922
a185955
e5bfd56
79d2062
60d1162
520959e
84561c7
32b8faf
b4fdb2f
bb7ae9d
34a1fdc
5ceced5
52a6376
938e62e
7c6cfdc
20db20b
7e9165e
307d871
6730e77
a8b5999
0ca6f49
b62f156
b0b21ab
9a44c07
5996e51
8ada7e8
47a80be
9e69554
72f3348
89fb93c
ac0a111
3df2946
ec563fa
a9483ba
dea242a
7057f53
22029cf
d217a33
c7dca38
672bd43
df85073
7e8f58a
172897b
a752a7d
5b962b0
8f02671
be86b60
55eaa57
1a81ccc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| server/serverHelpers/serverUtilities.ts(474,1): error TS1128: Declaration or statement expected. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Debugging artifact committed to the repository.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is leftover debug output and should not be committed to the repo. The TypeScript error it records ( |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silent behavioral change:
loggerparameter is now ignored.The previous code was
this.#logger = logger || loggerWithTag(this.#appName), which used a caller-supplied logger when provided. This PR drops the fallback and always callsloggerWithTag. Any caller (including tests using a mock logger) that passes aloggerargument now has it silently discarded, which breaks the contract without changing the constructor signature. Ifloggeris no longer part of the intended API, remove it from the constructor parameter list and update all call sites; otherwise restore the|| loggerfallback.