fix: backfill schemaDefined on replicas missing the flag - #503
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Reviewed; no blockers found. |
cb1kenobi
approved these changes
May 11, 2026
cb1kenobi
left a comment
cb1kenobi
left a comment
Member
There was a problem hiding this comment.
I don't know much about this, but makes sense. It would be nice if it was easy to add a test that demonstrates this fixes things.
Member
|
What is the situation where this can occur? I thought line 907 in databases.ts consistently set this flag. |
ldt1996
added a commit
that referenced
this pull request
May 26, 2026
When the on-disk primary-attribute descriptor in attributesDbi lacks schemaDefined (the state replica nodes were left in by 4.7.x deploys with replicated=true), re-entering table() must: - heal Table.schemaDefined in memory, and - rewrite the descriptor with schemaDefined: true on disk. The test strips the flag from a freshly created descriptor, drops the in-memory state via resetDatabases (mimicking a process restart on a replica), re-calls table(), and asserts both the in-memory class and the persisted descriptor have schemaDefined: true. Addresses the PR #503 review request to exercise the needsSchemaDefinedBackfill branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
@kriszyp I think that line just sets the local variable... from what I can tell it only gets persisted via the new table branch, and the existing table branch doesn't seem to rewrite the descriptor, so once a replica ends up on disk without the flag the defaulting probably can't reach back. My guess is that's what 4.7.x replicated=true deploys were producing |
kriszyp
pushed a commit
that referenced
this pull request
Jun 2, 2026
When the on-disk primary-attribute descriptor in attributesDbi lacks schemaDefined (the state replica nodes were left in by 4.7.x deploys with replicated=true), re-entering table() must: - heal Table.schemaDefined in memory, and - rewrite the descriptor with schemaDefined: true on disk. The test strips the flag from a freshly created descriptor, drops the in-memory state via resetDatabases (mimicking a process restart on a replica), re-calls table(), and asserts both the in-memory class and the persisted descriptor have schemaDefined: true. Addresses the PR #503 review request to exercise the needsSchemaDefinedBackfill branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
kriszyp
force-pushed
the
fix/schemadefined-on-replicated-tables
branch
from
June 2, 2026 19:20
1f2f850 to
196b585
Compare
When the on-disk primary-attribute descriptor in attributesDbi lacks schemaDefined (the state replica nodes were left in by 4.7.x deploys with replicated=true), re-entering table() must: - heal Table.schemaDefined in memory, and - rewrite the descriptor with schemaDefined: true on disk. The test strips the flag from a freshly created descriptor, drops the in-memory state via resetDatabases (mimicking a process restart on a replica), re-calls table(), and asserts both the in-memory class and the persisted descriptor have schemaDefined: true. Addresses the PR #503 review request to exercise the needsSchemaDefinedBackfill branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Mirrors the fix Kris applied to northwind.test.mjs (48179a1). On Bun shard 2, embed-directive tear-down (HNSW flush) starves the job processor, so csv_data_load sits IN_PROGRESS past the default 30s. Same suite, same shard, same fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kriszyp
force-pushed
the
fix/schemadefined-on-replicated-tables
branch
from
June 16, 2026 13:15
7e8cf9c to
1393cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.