Skip to content

feat(deploy-component): add install_allow_scripts flag #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriszyp merged 2 commits into from
May 20, 2026
Merged

feat(deploy-component): add install_allow_scripts flag #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c93c9c3
feat(deploy-component): add install_allow_scripts flag
kriszyp May 20, 2026
ebc5cfe
feat(add-component): add install_allow_scripts flag (consistent with …
kriszyp May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/operations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ async function addComponent(req) {

log.trace(`adding component`);
const cfDir = configUtils.getConfigPath(hdbTerms.CONFIG_PARAMS.COMPONENTSROOT);
const { project, install_command, install_timeout } = req;
const { project, install_command, install_timeout, install_allow_scripts } = req;

const template = req.template || 'https://github.com/harperdb/application-template';

Expand All @@ -230,6 +230,7 @@ async function addComponent(req) {
install: {
command: install_command,
timeout: install_timeout,
allowInstallScripts: install_allow_scripts,
},
});
await prepareApplication(application);
Expand Down Expand Up @@ -375,10 +376,11 @@ async function deployComponent(req) {

const applicationConfig = { package: req.package };
// Avoid writing an empty `install:` block
if (req.install_command || req.install_timeout) {
if (req.install_command || req.install_timeout || req.install_allow_scripts !== undefined) {
applicationConfig.install = {
command: req.install_command,
timeout: req.install_timeout,
allowInstallScripts: req.install_allow_scripts,
};
}
await configUtils.addConfig(req.project, applicationConfig);
Expand All @@ -391,6 +393,7 @@ async function deployComponent(req) {
install: {
command: req.install_command,
timeout: req.install_timeout,
allowInstallScripts: req.install_allow_scripts,
},
});

Expand Down
2 changes: 2 additions & 0 deletions components/operationsValidation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ function addComponentValidator(req) {
template: Joi.string().optional(),
install_command: Joi.string().optional(),
install_timeout: Joi.number().optional(),
install_allow_scripts: Joi.boolean().optional(),
});

return validator.validateBySchema(req, addFuncSchema);
Expand Down Expand Up @@ -239,6 +240,7 @@ function deployComponentValidator(req) {
restart: Joi.alternatives().try(Joi.boolean(), Joi.string().valid('rolling')).optional(),
install_command: Joi.string().optional(),
install_timeout: Joi.number().optional(),
install_allow_scripts: Joi.boolean().optional(),
force: Joi.boolean().optional(),
});

Expand Down
Loading