Skip to content

chore(renovate): enable auto-merge for dependency updates - #709

Merged
kriszyp merged 1 commit into
mainfrom
kris/cool-bhabha-b34991
May 22, 2026
Merged

chore(renovate): enable auto-merge for dependency updates#709
kriszyp merged 1 commit into
mainfrom
kris/cool-bhabha-b34991

Conversation

@kriszyp

@kriszyp kriszyp commented May 21, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds "automerge": true at the top level of renovate.json so Renovate will automatically merge PRs once CI passes

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment thread renovate.json
"prConcurrentLimit": 2,
"minimumReleaseAge": "7 days",
"internalChecksFilter": "strict",
"automerge": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top-level automerge: true applies to major version bumps too.

None of the existing packageRules adds "automerge": false for major updates, so a major dependency release will be merged automatically once CI passes and the 7-day age window clears — no human review required.

For a core infrastructure package this is a meaningful supply chain exposure: a compromised or breaking major release gets merged without any maintainer eyes on it. Minor/patch automerge is generally fine given the minimumReleaseAge+internalChecksFilter guards, but major updates typically warrant human sign-off.

Suggested change
"automerge": true,
"automerge": true,
"major": { "automerge": false },

Or equivalently as a packageRules entry:

{ "matchUpdateTypes": ["major"], "automerge": false }

@claude

claude Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

1 finding.

1. automerge: true applies to major version updates

File: renovate.json:10
What: The top-level automerge: true has no matching packageRule that sets automerge: false for matchUpdateTypes: ["major"], so major dependency bumps will be merged automatically once CI passes.
Why it matters: CI passing on a major update doesn't guarantee the dependency is safe or non-breaking. For a core infrastructure package, an auto-merged compromised or breaking major release can cascade to all downstream consumers without any maintainer review.
Suggested fix: Add "major": { "automerge": false } (or an equivalent packageRules entry) to restrict auto-merge to minor/patch updates only.

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major or otherwise I think this is reasonable. If 7-day age + CI passes, ship it. If something breaks, we'll find out and then can fix.

@kriszyp
kriszyp requested a review from dawsontoth May 21, 2026 22:54
@kriszyp
kriszyp merged commit e2a8f01 into main May 22, 2026
37 of 39 checks passed
@kriszyp
kriszyp deleted the kris/cool-bhabha-b34991 branch May 22, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants