DO NOT MERGE - pin django version to 4.x for postgres 13.x compat #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this draft PR to raise awareness (DO NOT MERGE).
We are currently running RDS Postgres 13.x, but catchpy installs Django 5.2 which dropped support for Postgres 13.x:
A workaround is to pin Django to 4.x until we upgrade RDS Postgres to 14.x or higher (hopefully this summer?). I don't intend to merge this to
mainsince that should ideally track the upstream repo and not diverge. Also, the recent changes and discussion in the upstream repository make it clear that DARTH is running Django 5.x, so pinning to Django 4.x would cause issues for them.For now, use this temporary branch (
django4) to build docker images until we upgrade RDS Postgres to 14+. When that is done, please close this PR and delete the branch.