CI: wheels script, gitignore, allow underscores in model names#100
CI: wheels script, gitignore, allow underscores in model names#100austinschneider wants to merge 1 commit into
Conversation
dd59508 to
ee24add
Compare
d00f148 to
f15cfc2
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates CI/packaging helpers to support wheel builds and adjusts ignored files/directories for the repo’s data/layout changes.
Changes:
- Install GSL during
cibuildwheel“before_all” step on Linux/macOS. - Add ignores for a flux data directory and a helper script.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/wheels/cibw_before_all.sh | Adds OS/package-manager specific GSL installation steps for wheel builds. |
| .gitignore | Ignores a specific resources subdirectory and a script file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| apk add gsl-dev # musllinux (Alpine) | ||
| else | ||
| yum install -y gsl-devel # manylinux (CentOS/RHEL) |
There was a problem hiding this comment.
apk add without --no-cache tends to leave package index/cache behind, which can slow CI and increase container layer size. Consider using apk add --no-cache gsl-dev; similarly consider cleaning yum metadata after install (e.g., yum clean all) if these images persist across steps.
| apk add gsl-dev # musllinux (Alpine) | |
| else | |
| yum install -y gsl-devel # manylinux (CentOS/RHEL) | |
| apk add --no-cache gsl-dev # musllinux (Alpine) | |
| else | |
| yum install -y gsl-devel && yum clean all # manylinux (CentOS/RHEL) |
| fi | ||
| elif [[ $RUNNER_OS == "macOS" ]]; then | ||
| : | ||
| brew install gsl |
There was a problem hiding this comment.
PR title mentions "allow underscores in model names", but this PR’s squashed diff only touches .gitignore and tools/wheels/* (plus the GSL install here). Either the title should be updated to reflect the actual changes, or the missing change should be included in this PR/linked to the correct stacked PR.
ee24add to
02a959b
Compare
f15cfc2 to
8259988
Compare
02a959b to
2a95b5f
Compare
8259988 to
c7a4994
Compare
|
Closing to reopen from the commit author's account so they can be added as a reviewer. Branch unchanged; will be re-linked from the new PR shortly. |
Stack: PR 2 of 14
This PR is part of a 14-PR stack decomposing
dev/HNL_DISinto reviewable chunks.chore/vendor-crundec3chore/ci-and-packagingMerge order:
chore/vendor-crundec3should land before this PR.Squashed contents
Squashed diff for paths:
Source commits on dev/HNL_DIS_clean that contributed:
088b1cd (Nicholas Kamp): move around the HNL DIS fits files
0a8a6e9 (Nicholas Kamp): attempt to get wheels working
a62ce38 (Nicholas Kamp): quick gitignore change
Notes
dev/HNL_DIS_clean..fitsdata files have been removed from the branch and are packaged separately.