Skip to content

CI: wheels script, gitignore, allow underscores in model names#100

Closed
austinschneider wants to merge 1 commit into
chore/vendor-crundec3from
chore/ci-and-packaging
Closed

CI: wheels script, gitignore, allow underscores in model names#100
austinschneider wants to merge 1 commit into
chore/vendor-crundec3from
chore/ci-and-packaging

Conversation

@austinschneider

Copy link
Copy Markdown
Collaborator

Stack: PR 2 of 14

This PR is part of a 14-PR stack decomposing dev/HNL_DIS into reviewable chunks.

  • Base: chore/vendor-crundec3
  • Head: chore/ci-and-packaging

Merge order: chore/vendor-crundec3 should land before this PR.

Squashed contents

Squashed diff for paths:

  • .gitignore
  • tools/wheels

Source commits on dev/HNL_DIS_clean that contributed:
088b1cd (Nicholas Kamp): move around the HNL DIS fits files
0a8a6e9 (Nicholas Kamp): attempt to get wheels working
a62ce38 (Nicholas Kamp): quick gitignore change

Notes

  • This branch is the squashed cumulative diff of the listed source commits. Per-commit history is browsable on dev/HNL_DIS_clean.
  • Large .fits data files have been removed from the branch and are packaged separately.

Squashed diff for paths:
  - .gitignore
  - tools/wheels

Source commits on dev/HNL_DIS_clean that contributed:
  088b1cd (Nicholas Kamp): move around the HNL DIS fits files
  0a8a6e9 (Nicholas Kamp): attempt to get wheels working
  a62ce38 (Nicholas Kamp): quick gitignore change
Copilot AI review requested due to automatic review settings April 28, 2026 04:28
@austinschneider austinschneider force-pushed the chore/ci-and-packaging branch from d00f148 to f15cfc2 Compare April 28, 2026 04:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates CI/packaging helpers to support wheel builds and adjusts ignored files/directories for the repo’s data/layout changes.

Changes:

  • Install GSL during cibuildwheel “before_all” step on Linux/macOS.
  • Add ignores for a flux data directory and a helper script.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
tools/wheels/cibw_before_all.sh Adds OS/package-manager specific GSL installation steps for wheel builds.
.gitignore Ignores a specific resources subdirectory and a script file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +38
apk add gsl-dev # musllinux (Alpine)
else
yum install -y gsl-devel # manylinux (CentOS/RHEL)

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apk add without --no-cache tends to leave package index/cache behind, which can slow CI and increase container layer size. Consider using apk add --no-cache gsl-dev; similarly consider cleaning yum metadata after install (e.g., yum clean all) if these images persist across steps.

Suggested change
apk add gsl-dev # musllinux (Alpine)
else
yum install -y gsl-devel # manylinux (CentOS/RHEL)
apk add --no-cache gsl-dev # musllinux (Alpine)
else
yum install -y gsl-devel && yum clean all # manylinux (CentOS/RHEL)

Copilot uses AI. Check for mistakes.
fi
elif [[ $RUNNER_OS == "macOS" ]]; then
:
brew install gsl

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title mentions "allow underscores in model names", but this PR’s squashed diff only touches .gitignore and tools/wheels/* (plus the GSL install here). Either the title should be updated to reflect the actual changes, or the missing change should be included in this PR/linked to the correct stacked PR.

Copilot uses AI. Check for mistakes.
@austinschneider

Copy link
Copy Markdown
Collaborator Author

Closing to reopen from the commit author's account so they can be added as a reviewer. Branch unchanged; will be re-linked from the new PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants