Scalar (mediator) Dark Matter at CCM by austinschneider · Pull Request #92 · Harvard-Neutrino/SIREN

austinschneider · 2025-12-23T16:31:55Z

No description provided.

…stribution classes that sample from raw data distributions

… to the same variable when sampled. Troubleshooted injector.cxx script with print statents to show argon interaction occuring at every interaction for some reason

…ine class

…otaldecaywidth refers to decay width of a specific process/final state and totaldecaywidthallfinalstates is summed up total decay width across all final states. same for decay length.

…ting new points.

Copilot

Pull request overview

This PR adds support for Scalar (mediator) Dark Matter at the CCM detector. The changes include API refactoring to distinguish between total decay widths across all final states versus specific final states, infrastructure improvements to handle injection attempts and step lengths, and new distribution classes for sampling pre-generated kinematics data.

Key changes:

Refactored decay API to separate TotalDecayWidthAllFinalStates from TotalDecayWidth for better clarity
Added injection attempt tracking and step length propagation through the event generation pipeline
Introduced three new distribution classes for sampling from pre-generated data (position, energy, and full kinematics)
Enhanced error handling in Romberg integration and detector model intersection calculations
Fixed various bugs in direction handling and column depth calculations

Reviewed changes

Copilot reviewed 54 out of 59 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
vendor/photospline	Updated subproject commit
vendor/cereal	Updated subproject commit
resources/processes/SDMCrossSection/process.py	New scalar dark matter cross section calculation implementation
resources/examples/example2/PaperPlots.ipynb	Updated Python version reference
python/_util.py	Added early return for missing detector resources
python/init.py	Added success message on import
python/Weighter.py	Removed validation check for primary physical distributions
projects/utilities/public/SIREN/utilities/Pybind11Trampoline.h	Added new trampoline macros for reference return types
projects/utilities/public/SIREN/utilities/Integration.h	Enhanced Romberg integration with better error handling
projects/interactions/public/SIREN/interactions/*	Renamed decay methods across multiple headers for API clarity
projects/interactions/private/*	Updated implementations to match new decay API
projects/injection/public/SIREN/injection/Weighter.tcc	Updated to use new decay length methods
projects/injection/public/SIREN/injection/Injector.h	Added injection attempts tracking
projects/injection/private/Injector.cxx	Refactored event generation error handling and added injection attempt counter
projects/injection/private/WeightingUtils.cxx	Updated target calculation and added zero probability check
projects/distributions/public/SIREN/distributions/primary/*	Added three new distribution classes for sampling
projects/distributions/private/*	Implementation files for new distributions and bug fixes
projects/detector/private/DetectorModel.cxx	Fixed direction handling and enhanced target validation
projects/dataclasses/public/SIREN/dataclasses/*	Added injection_step_length field to particle and record structures
cmake/parse_pyproject.py	Fixed import error handling
CMakeLists.txt	Added debug configuration and Python staging directory

Comments suppressed due to low confidence (7)

resources/processes/SDMCrossSection/process.py:1

Variable m_e is defined on line 37 but then redefined on line 61 with a different value (0.000511 vs 0.00051099892). This duplicate definition will cause the first definition to be overwritten, which may lead to inconsistent behavior.
resources/processes/SDMCrossSection/process.py:1
Function name sm_masses conflicts with the dictionary defined on line 18. This shadowing makes the dictionary inaccessible after this function definition and could cause confusion.
resources/processes/SDMCrossSection/process.py:1
Parameter m_nucleus is duplicated in the function signature. The parameter appears twice at positions 3 and 5, which is a syntax error in Python.
resources/processes/SDMCrossSection/process.py:1
References to self (lines 156, 165) in a standalone function get_CM_factors. This function is not a method and has no self parameter, which will cause a NameError at runtime.
resources/processes/SDMCrossSection/process.py:1
Attribute self.g_gamgam is used but not defined in the __init__ method. The class initializes self.g_phi_e_e instead. This will cause an AttributeError.
python/init.py:1
The import of builtins on line 58 appears unused, and the print statement on line 59 is not appropriate for a production library as it produces output on every import.
projects/utilities/public/SIREN/utilities/Integration.h:1
Returning ext when extErr is NaN could propagate invalid numerical results. Consider throwing an exception or logging an error instead of silently returning a potentially incorrect value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-23T16:36:08Z

        }
+        primary_record.Finalize(record);
+        SampleCrossSection(record);
+        injected_events += 1;


Returning an empty InteractionTree on injection failure (line 305) but then incrementing injected_events on line 345. This creates inconsistency where failed injections are counted as successful events.

Suggested change

injected_events += 1;

Copilot · 2025-12-23T16:36:08Z

+SamplePrimaryPositionDistribution::SamplePrimaryPositionDistribution(std::vector<siren::math::Vector3D> positions, std::vector<double> weights)
+    : positions_(positions), weights_(weights) {
+    if (weights_.empty()) {
+        std::cout << "Caution: No weights are used in association with the position data. This assumes you're data is unbiased and it will be sampled uniformly!" << std::endl;


Corrected spelling of 'you're' to 'your'.

Suggested change

std::cout << "Caution: No weights are used in association with the position data. This assumes you're data is unbiased and it will be sampled uniformly!" << std::endl;

std::cout << "Caution: No weights are used in association with the position data. This assumes your data is unbiased and it will be sampled uniformly!" << std::endl;

Copilot · 2025-12-23T16:36:09Z

+SamplePrimaryEnergyDistribution::SamplePrimaryEnergyDistribution(std::vector<double> energies, std::vector<double> weights)
+    : energies_(energies), weights_(weights) {
+    if (weights_.empty()) {
+        std::cout << "Caution: No weights are used in association with the position data. This assumes you're data is unbiased and it will be sampled uniformly!" << std::endl;


Corrected spelling of 'you're' to 'your'. Also, the message mentions 'position data' when it should refer to 'energy data'.

Suggested change

std::cout << "Caution: No weights are used in association with the position data. This assumes you're data is unbiased and it will be sampled uniformly!" << std::endl;

std::cout << "Caution: No weights are used in association with the energy data. This assumes your data is unbiased and it will be sampled uniformly!" << std::endl;

Copilot · 2025-12-23T16:36:09Z

    ss << "position=(" << p.position.at(0) << ", " << p.position.at(1) << ", " << p.position.at(2) << "), ";
    ss << "length=" << p.length << ", ";
    ss << "helicity=" << p.helicity;
+    ss << "injection_step_length=" << p.injection_step_length;


Missing comma separator before injection_step_length in the representation string. All other fields are separated by commas, but this one is missing the preceding comma.

Suggested change

ss << "injection_step_length=" << p.injection_step_length;

ss << ", injection_step_length=" << p.injection_step_length;

Copilot · 2025-12-23T16:36:09Z

+       p.injection_step_length = GetInjectionStepLength();
+    } catch(...) {
+        p.injection_step_length = 0;
+    }


Function GetParticle() is missing a return statement after the try-catch block (around line 58). The function should return p after setting the injection_step_length.

Suggested change

}

}

return p;

Copilot · 2025-12-23T16:36:10Z

 try:
    import tomllib  # Python 3.11+
-except ImportError:
+except ModuleNotFoundError:


Changed from ImportError to ModuleNotFoundError, but ModuleNotFoundError is a subclass of ImportError and only exists in Python 3.6+. This reduces backward compatibility unnecessarily.

Copilot · 2025-12-23T16:36:10Z

 SET(CMAKE_CXX_STANDARD 14)
 SET(CMAKE_C_STANDARD 99)

+set(CMAKE_BUILD_TYPE Debug)


Forcing CMAKE_BUILD_TYPE to Debug unconditionally (line 43) overrides user preferences and conflicts with the logic on lines 47-48 that provides a default only when not set. This should respect existing CMAKE_BUILD_TYPE settings.

Suggested change

set(CMAKE_BUILD_TYPE Debug)

This reverts commit dc60980.

…fter setting new points." This reverts commit e286691.

This reverts commit e0f8ebe.

This reverts commit 851dc6b.

…ctor is at 0,0 (old version of density is now backup_densities.dat)

collinoconnor34 and others added 15 commits July 17, 2025 11:09

Fixed detector.py warning in _utils.py and made primary energy and di…

d49864d

…stribution classes that sample from raw data distributions

Sample distribution class made for kinematic variabls that correspond…

07d2f04

… to the same variable when sampled. Troubleshooted injector.cxx script with print statents to show argon interaction occuring at every interaction for some reason

updates for current Decay class

de6e3e1

BUG: pyDecay should handle CrossSectionDistributionRecord by reference

99e827d

MAINT: new pybind macro for passing arguments by reference in trampol…

f199295

…ine class

matching naming convention between decay and cross section. namely, t…

49d253b

…otaldecaywidth refers to decay width of a specific process/final state and totaldecaywidthallfinalstates is summed up total decay width across all final states. same for decay length.

removing requirement for function

37e875f

fixing logic for generating events to avoid getting stuck in loops

c677431

fixing edgecases

dc60980

Normalize direction just in case. Clip path to outer bounds after set…

e286691

…ting new points.

Check number of intersections

e0f8ebe

Correct sign flip on *ToPoint methods

851dc6b

fixing weighting

d7045ca

calculate available targets the same way between weighter and injectors

dd0ad4a

remove check on primary physical distributions

a1f878b

Copilot AI review requested due to automatic review settings December 23, 2025 16:31

Copilot AI reviewed Dec 23, 2025

View reviewed changes

darcynewmark added 12 commits January 11, 2026 10:19

Revert "fixing edgecases"

0ed689c

This reverts commit dc60980.

Revert "Normalize direction just in case. Clip path to outer bounds a…

4b66771

…fter setting new points." This reverts commit e286691.

Revert "Check number of intersections"

b2da017

This reverts commit e0f8ebe.

t sttRevert "Correct sign flip on *ToPoint methods"

2a0bfda

This reverts commit 851dc6b.

rotated positions so the target is centered around -18, -14m and dete…

738607a

…ctor is at 0,0 (old version of density is now backup_densities.dat)

rotated gamma positions as well to match ccm geometry

9fbe920

header

9ffa0c9

fix a few rotations

b1585cb

cleaner fix by adding rotation -- works as expected

879e6e9

functions for returning each part of the weights individually

f2342db

remove extra increment of injected_events

c008e9b

add target disk that is in mark-iv target

62718a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scalar (mediator) Dark Matter at CCM#92

Scalar (mediator) Dark Matter at CCM#92
austinschneider wants to merge 27 commits into
mainfrom
sdm

austinschneider commented Dec 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	std::cout << "Caution: No weights are used in association with the position data. This assumes you're data is unbiased and it will be sampled uniformly!" << std::endl;
	std::cout << "Caution: No weights are used in association with the position data. This assumes your data is unbiased and it will be sampled uniformly!" << std::endl;

	ss << "injection_step_length=" << p.injection_step_length;
	ss << ", injection_step_length=" << p.injection_step_length;

Conversation

austinschneider commented Dec 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants