Draft
Conversation
Member
|
worth the read, thanks. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of stream of consciousness on what's happening here: when reviewing #42, I got confused and followed an itch to rewrite a few helpers. Then I wanted to test the new implementation against the old, and found it awkward to have to switch between
/testsand/src, so I started to implement the test suite in the prod modules. I think this would only increase the binary sizes a little, not runtime performance, while on the other hand moving tests and tested code closer together, which would make it more accessible and easier to handle. Kinda what I like about doctests. Then I found that the types accomodate illegal values, and the tests fail because of my naiveArbitraryinstances. Then I was calculating how much time I have left before I need to take an extensive break from this project again, and grew a bit weary.So I decided to at least share how far I got. Maybe you like the idea of testing in prod, and maybe you like my alternative implementations of the helpers. Please steal any and all of it, or give me a thumbs up and I might get this into a mergeable shape at some point.