-
Notifications
You must be signed in to change notification settings - Fork 29
feat: reown #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreabadesso
wants to merge
187
commits into
master
Choose a base branch
from
feat/reown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: reown #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
previously approved these changes
Mar 20, 2025
tuliomir
previously approved these changes
Mar 24, 2025
Hey! From a UX/UI perspective, I’d suggest rewriting the operation labels in the modal to be more user-friendly. Instead of showing raw method names, we could display descriptive actions to improve clarity: This dApp is requesting permission to: |
9babd3c
d9e62a3
to
2a2587a
Compare
2a2587a
to
66fed12
Compare
214775f
to
cf10a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-01-02.at.10.39.57.mov
Acceptance Criteria
CreateNanoContractTx
andSignOracleData
Security Checklist