Skip to content

feat: reown #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 187 commits into
base: master
Choose a base branch
from
Open

feat: reown #713

wants to merge 187 commits into from

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Dec 26, 2024

Screen.Recording.2025-01-02.at.10.39.57.mov

Acceptance Criteria

  • We should support reown connections, including adding new ones and managing existing
  • We should support all nano contract operations, including CreateNanoContractTx and SignOracleData
  • The wallet-desktop production build should be protected with LavaMoat

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Dec 26, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Dec 26, 2024
pedroferreira1
pedroferreira1 previously approved these changes Mar 20, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 20, 2025
@andreabadesso andreabadesso moved this from In Review (Done) to In Progress (Done) in Hathor Network Mar 20, 2025
@andreabadesso andreabadesso moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 20, 2025
tuliomir
tuliomir previously approved these changes Mar 24, 2025
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 26, 2025
@anafigueired
Copy link

Hey! From a UX/UI perspective, I’d suggest rewriting the operation labels in the modal to be more user-friendly. Instead of showing raw method names, we could display descriptive actions to improve clarity:

This dApp is requesting permission to:
• Sign a message with your address
• Create and send a Nano Contract transaction

@andreabadesso andreabadesso dismissed stale reviews from tuliomir and pedroferreira1 via 9babd3c April 16, 2025 14:49
@andreabadesso andreabadesso force-pushed the feat/reown branch 2 times, most recently from d9e62a3 to 2a2587a Compare April 16, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Review (Done)
Development

Successfully merging this pull request may close these issues.

4 participants