Move string strip in serialize_row#5
Open
willeppy wants to merge 1 commit into
Open
Conversation
I'm using
- Python version 3.10.4
- Pandas version 1.4.4
and was running into an issue with the example run script from the Readme:
```bash
python3 -m fm_data_tasks.run_inference \
--dry_run \
--num_run 10 \
--k 3 \
--sample_method random \
--data_dir data/datasets/entity_matching/structured/Fodors-Zagats
```
errors out with
```bash
AttributeError: 'int' object has no attribute 'strip'
```
Since the row value is not always a string.
Moving the strip to outside the string format should fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
and was running into an issue with the example run script from the Readme:
python3 -m fm_data_tasks.run_inference \ --dry_run \ --num_run 10 \ --k 3 \ --sample_method random \ --data_dir data/datasets/entity_matching/structured/Fodors-Zagatserrors out with
Since the row value is not always a string.
Moving the strip to outside the string format should fix this.