Skip to content

Mapping rules JSON V2 - #1145

Merged
AndrewThien merged 33 commits into
masterfrom
Ariflow_v2_JSON
Aug 1, 2025
Merged

Mapping rules JSON V2#1145
AndrewThien merged 33 commits into
masterfrom
Ariflow_v2_JSON

Conversation

@AndrewThien

@AndrewThien AndrewThien commented Jul 8, 2025

Copy link
Copy Markdown
Member

✨ Feature

PR Description

This PR added the function to build version 2 of Mapper's mapping rules JSON (version 1 function is kept intact, only moved down to near the v2 function).
The structure changes are the main focus of this PR. It will help to solve the issue about value_as_concept_id (#1008) in the future.

Related Issues or other material

Closes #1142

@AndrewThien
AndrewThien marked this pull request as ready for review July 14, 2025 15:38
@AndrewThien
AndrewThien requested a review from AndyRae as a code owner July 14, 2025 15:38
@AndrewThien AndrewThien changed the title Ariflow v2 json Mapping rules JSON V2 Jul 14, 2025
@AndrewThien
AndrewThien requested a review from brian-kim31 July 14, 2025 15:45
brian-kim31
brian-kim31 previously approved these changes Jul 17, 2025
@AndrewThien

Copy link
Copy Markdown
Member Author

When you have time, can you double-test this one, please? @brian-kim31, if you haven't done so?
Please test (and compare to V1) using many scenarios and domains, etc.

@brian-kim31

Copy link
Copy Markdown
Contributor

When you have time, can you double-test this one, please? @brian-kim31, if you haven't done so?
Please test (and compare to V1) using many scenarios and domains, etc.

Sure I'll test it

@brian-kim31

Copy link
Copy Markdown
Contributor

@AndrewThien The new JSON format is much easier to work with. It organizes everything by source table, so you don’t have to repeat the same info over and over. Field and concept mappings are grouped in a way that’s cleaner and more logical, and it’s easier to see how source data connects to the final model. It also makes updates and future changes more straightforward, especially when handling larger datasets or multiple concepts in one go. Approved.

@AndrewThien
AndrewThien merged commit 15154d1 into master Aug 1, 2025
16 checks passed
@AndrewThien
AndrewThien deleted the Ariflow_v2_JSON branch August 1, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 2 of JSON rules from Airflow DAG

3 participants