Added Show users on datasets/scan reports - #1165
Merged
Merged
Conversation
Member
|
I can see why this looks like a small issue to tackle, and why you'd take this approach given the existing codebase and how it fetches / resolves this pattern generally. But this is really an iceberg issue - looks small, but there's a bunch of debt it's building on. The ideal pattern for this is to mirror the existing Unfortunately - the pattern is not the case for So what do to?
|
AndyRae
reviewed
Jul 31, 2025
AndyRae
previously approved these changes
Aug 1, 2025
AndyRae
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Feature
PR Description
This PR implements member display functionality across datasets and scan reports by creating dedicated API functions (getDatasetMembers() and getScanReportMembers()) that aggregate and deduplicate users from multiple permission levels (viewers, editors, and admins for datasets; viewers and editors for scan reports). The implementation integrates with existing layout components to show all users with access to each resource using the AvatarList component, which displays member avatars with tooltips and a count indicator. This provides users with immediate visibility into who has access to datasets and scan reports, improving collaboration and access management while maintaining the existing permission structure and ensuring backward compatibility.
Related Issues or other material
Related #1073
Closes #1073
Screenshots, example outputs/behaviour etc.