Complete adding death_table boolean to SR table and update rules + migration - #1291
Merged
Conversation
brian-kim31
marked this pull request as draft
February 24, 2026 09:34
brian-kim31
marked this pull request as ready for review
February 25, 2026 14:02
prquinlan
reviewed
Mar 2, 2026
prquinlan
left a comment
prquinlan
left a comment
Contributor
There was a problem hiding this comment.
One comment on the ordering of the if statements
prquinlan
approved these changes
Mar 3, 2026
prquinlan
left a comment
prquinlan
left a comment
Contributor
There was a problem hiding this comment.
thanks for the changes
AndyRae
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Feature
PR Description
This PR adds
death_tableboolean to SR table, updates rules to support finding the correct destination table and adds death to them_allowed_tableslist, plus new migrations for the Scan Report table.Screenshot
Before
After
Related Issues or other material
Related #1282
Closes #1282