Fix player overlay deck panel visibility toggles - #4737
Open
numbereleven-a wants to merge 1 commit into
Open
Conversation
numbereleven-a
marked this pull request as ready for review
June 30, 2026 08:49
Contributor
|
Hello, thanks for your PR! The skipping in UpdatePlayerLayout is not the right approach, and instead the existing pattern is to set visibilities in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4681.
This updates the player overlay layout handling so the visibility toggles for:
are respected by both the main in-game overlay and the standalone player window.
The checkbox handlers now also rebuild the main overlay layout and refresh the current card lists after a visibility change. This prevents the E.T.C.'s Band panel from staying visible after being disabled, and prevents it from coming back empty when toggled off and on again.
Validation
Tested in-game with a constructed deck containing E.T.C., Band Manager and a filled E.T.C. band.
Before the fix:
E.T.C.'s Bandoption did not hide the panel;After the fix:
E.T.C.'s Bandhides the panel immediately;Build validation:
Hearthstone Deck Tracker.csprojDebugx86