Skip to content

Fix player overlay deck panel visibility toggles - #4737

Open
numbereleven-a wants to merge 1 commit into
HearthSim:masterfrom
numbereleven-a:bughunt/player-overlay-panel-visibility
Open

Fix player overlay deck panel visibility toggles#4737
numbereleven-a wants to merge 1 commit into
HearthSim:masterfrom
numbereleven-a:bughunt/player-overlay-panel-visibility

Conversation

@numbereleven-a

Copy link
Copy Markdown
Contributor

Summary

Fixes #4681.

This updates the player overlay layout handling so the visibility toggles for:

  • cards above the deck
  • cards below the deck
  • E.T.C.'s Band

are respected by both the main in-game overlay and the standalone player window.

The checkbox handlers now also rebuild the main overlay layout and refresh the current card lists after a visibility change. This prevents the E.T.C.'s Band panel from staying visible after being disabled, and prevents it from coming back empty when toggled off and on again.

Validation

Tested in-game with a constructed deck containing E.T.C., Band Manager and a filled E.T.C. band.

Before the fix:

  • the E.T.C.'s Band panel was visible in the player overlay;
  • disabling the E.T.C.'s Band option did not hide the panel;
  • after partial layout refresh changes, toggling it off and on could bring the panel back empty.

After the fix:

  • disabling E.T.C.'s Band hides the panel immediately;
  • enabling it again restores the panel with all three band cards;
  • repeated off/on toggles keep working correctly;
  • the same layout visibility checks are applied to the standalone player window.

Build validation:

  • Hearthstone Deck Tracker.csproj
  • Debug
  • x86

@numbereleven-a
numbereleven-a marked this pull request as ready for review June 30, 2026 08:49
@beheh

beheh commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Hello, thanks for your PR! The skipping in UpdatePlayerLayout is not the right approach, and instead the existing pattern is to set visibilities in Update in OverlayWindow.Update. I'll use this PR as a basis, but will push a clean version of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Unable to properly hide ETC's band and the cards at the bottom of the deck

2 participants