Battlegrounds opponent board not showing on hover - #4742
Open
JasonLandbridge wants to merge 1 commit into
Open
Conversation
2 tasks
JasonLandbridge
marked this pull request as ready for review
July 6, 2026 12:54
Contributor
Author
|
@beheh Hi, could you please merge this? |
…ents Board snapshots were stored by PLAYER_ID but retrieved via a two-step lookup (entityId → live entity → PLAYER_ID → snapshot). After opponents died, their hero entities were cleaned from _game.Entities, so GetSnapshot() returned null even though the snapshot was successfully captured during combat. Added LastKnownBoardStateByHeroEntityId dictionary as a direct entityId → snapshot index. GetSnapshot() now falls back to this direct lookup when the entity is no longer in the game state. Closes HearthSim#4700, HearthSim#4689
JasonLandbridge
force-pushed
the
fix-hover-enemy-bug
branch
from
July 31, 2026 14:21
52e92c6 to
0c1bd7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4700, #4689
I can confirm this works in both single and dual Hearthstone battlegrounds matches