Surface Arenasmith trial status and add diagnostics - #4759
Open
dokson wants to merge 1 commit into
Open
Conversation
Show a 'trials reset in X' hint in the arena pre-draft panel once the starter trials are used up, so users understand why Arenasmith stopped appearing instead of getting no feedback at all. Add trial diagnostics (remaining counts, reset hours and deck id) to the abort log paths to make future reports easier to triage. Also add tests for the arena pick API parsing and the diagnostics helper. Addresses HearthSim#4731
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #4731.
When the Arenasmith trials are used up, the overlay simply stops appearing with no feedback, which reads as "Arenasmith not showing".
This surfaces the trial state to the user and improves diagnosability:
Note: this targets the silent/no-feedback symptom. It does not attempt to fix cases where Arenasmith fails to show for other reasons, but the added logging makes those cases identifiable.
Validation
MessageTypeconverter,ParseContent) and the diagnostics helper — 42 tests passing.Build validation:
Hearthstone Deck Tracker.csproj/HDTTests.csprojDebugx86/x64