Support for vector_space_dim and friends for modules over MPoly(Quo)LocRing localized at a point #27
Draft
Syz-MS wants to merge 9 commits intoHechtiDerLachs:kbase_for_modulesfrom
Conversation
…ng the code from the MPolyQuoRing case
Author
|
Will open a new PR, since your PR is now merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HechtiDerLachs feel free to decide whether to include this in your current open PR or not, since it is already late and the deadline for the 1.7.0 release is approaching quickly.
To sum up the changes in this PR:
refactores the existing code for the ungraded
MPolyLocRingcase and extends it to modules with true sub part (left the old code commented out)in doing so swiches to using 'present_as_cokernel
instead ofcokernel` when presenting the module, since the later one sometimes also returns the canonical projectionalso left the code for the "total degree graded"
MPolyLocRingcase untouched, since there are two test in an old testset, that would break otherwise (should probably be removed)copys and refactors the "base_ring_lift" -functions for modules over a
MPolyQuoRingto the case of modules over aMPolyQuoLocRingadds full support for ungraded modules over a
MPolyQuoLocRing