Improve theming, Git status fetch, and UI consistency - #43
Merged
Conversation
Hefaistos68
commented
Dec 30, 2025
Hefaistos68
commented
Owner
- Added HierarchyLine color to ThemePalette and applied to tree view lines
- Enhanced label theming and header detection for better UI clarity
- Extended theming to additional panels (mainPanel, flowLayoutPanel1)
- Refactored designer code to use local variables and improved layout/margins
- Cleaned up .resx metadata and simplified font initialization
- Reworked Git status fetching to use a UI-thread snapshot, preventing concurrent modification issues
- Simplified repository lookup logic in Git status fetch
- Added error handling for TaskbarJumpList.Refresh() to prevent crashes
- Added HierarchyLine color to ThemePalette and applied to tree view lines - Enhanced label theming and header detection for better UI clarity - Extended theming to additional panels (mainPanel, flowLayoutPanel1) - Refactored designer code to use local variables and improved layout/margins - Cleaned up .resx metadata and simplified font initialization - Reworked Git status fetching to use a UI-thread snapshot, preventing concurrent modification issues - Simplified repository lookup logic in Git status fetch - Added error handling for TaskbarJumpList.Refresh() to prevent crashes
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the Visual Studio Launcher application with improvements to theming, Git status fetching, and UI consistency. The changes focus on better error handling, preventing concurrent modification issues, and extending theme support across more UI components.
Key Changes
- Refactored Git status fetching to use a UI-thread snapshot approach, preventing concurrent modification exceptions during tree iteration
- Added error handling for TaskbarJumpList.Refresh() to prevent application crashes
- Extended theming support with new HierarchyLine color and broader panel coverage (mainPanel, flowLayoutPanel1)
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| VSLauncherX/MainDialog.resx | Cleaned up duplicate metadata entries and updated embedded image data for btnExplorer and imageList3 |
| VSLauncherX/MainDialog.cs | Added try-catch block around TaskbarJumpList.Refresh() to prevent crashes from exceptions |
| VSLauncherX/MainDialog.Utilities.cs | Refactored Git status fetching with CollectGitTargets method to create UI-thread snapshot, preventing concurrent modifications; simplified repository lookup logic |
| VSLauncherX/MainDialog.Designer.cs | Refactored to use local variables instead of this.field pattern; simplified Font initialization by removing GraphicsUnit.Point parameter; improved margins and layout |
| VSLauncherX/Helpers/ThemeHelper.cs | Added HierarchyLine color to ThemePalette; extended header detection for labels; applied theming to mainPanel and flowLayoutPanel1; added tree hierarchy line color customization |
| VSLauncherX/Helpers/SecurityHelper.cs | Converted spaces to tabs for consistent indentation throughout the file |
| VSLauncherX/Helpers/AdminInfo.cs | Converted spaces to tabs for consistent indentation |
Files not reviewed (1)
- VSLauncherX/MainDialog.Designer.cs: Language not supported
| } | ||
| catch (Exception) | ||
| { | ||
| // whatever goes wrong, we can do anything about it |
There was a problem hiding this comment.
Typo in the comment: "we can do anything about it" should be "we can't do anything about it" (missing apostrophe in "can't").
Suggested change
| // whatever goes wrong, we can do anything about it | |
| // whatever goes wrong, we can't do anything about it |
Comment on lines
+376
to
+379
| catch (Exception) | ||
| { | ||
| // whatever goes wrong, we can do anything about it | ||
| } |
There was a problem hiding this comment.
The catch block catches all exceptions but doesn't log them. This could hide important errors such as permission issues or invalid state. Consider adding logging to help diagnose issues with TaskbarJumpList.Refresh() in production.
Suggested change
| catch (Exception) | |
| { | |
| // whatever goes wrong, we can do anything about it | |
| } | |
| catch (Exception ex) | |
| { | |
| // Log the exception so issues with TaskbarJumpList.Refresh can be diagnosed | |
| Trace.TraceError("Failed to refresh TaskbarJumpList: {0}", ex); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.