Skip to content

fix(holo): gray functional/action keys with dynamic colors in light mode #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiMoHo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(holo): gray functional/action keys with dynamic colors in light mode #2687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/src/main/java/helium314/keyboard/latin/common/Colors.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,15 @@ class DynamicColors(context: Context, override val themeStyle: String, override
drawable.colorFilter = getColorFilter(color)
return
}
DrawableCompat.setTintMode(drawable, PorterDuff.Mode.MULTIPLY)
// The Holo functional/action key backgrounds are grey nine-patches. Tinting them with
// MULTIPLY turns a light (e.g. dynamic/Material You) accent into grey (#2052), because
// grey * pastel stays grey. SRC_IN replaces the grey with the tint instead. Restricted to
// Holo light + these two backgrounds so tuned static themes and dark mode are unaffected.
val tintMode = if (themeStyle == STYLE_HOLO && !isNight
&& (color == FUNCTIONAL_KEY_BACKGROUND || color == ACTION_KEY_BACKGROUND))
PorterDuff.Mode.SRC_IN
else PorterDuff.Mode.MULTIPLY
DrawableCompat.setTintMode(drawable, tintMode)
DrawableCompat.setTintList(drawable, colorStateList)
}

Expand Down