Skip to content

Make the floating keyboard's drag/resize handles reachable #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiMoHo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the floating keyboard's drag/resize handles reachable #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/main/java/helium314/keyboard/latin/LatinIME.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,11 @@ public void onComputeInsets(final InputMethodService.Insets outInsets) {
touchLeft = xy.component1();
touchTop = xy.component2();
touchRight = touchLeft + mSettings.getCurrent().mFloatingWidth;
touchBottom = touchTop + mSettings.getCurrent().mFloatingHeight + stripHeight + (int)FloatingKeyboardUtils.getFloatingHandleHeight(getResources());
// the floating input view wraps the whole floating keyboard (suggestion strip + keyboard +
// drag/resize handles), so its measured height is the exact reach; the old estimate used the
// configured mFloatingHeight, which is smaller than the rendered keyboard, leaving the bottom
// handles outside the touchable region (touches fell through to the app behind)
touchBottom = touchTop + inputHeight;
}
outInsets.touchableInsets = InputMethodService.Insets.TOUCHABLE_INSETS_REGION;
outInsets.touchableRegion.set(touchLeft, touchTop, touchRight, touchBottom);
Expand Down
13 changes: 13 additions & 0 deletions app/src/main/java/helium314/keyboard/latin/utils/FloatingKeyboardUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@ import android.annotation.SuppressLint
import android.content.Context
import android.content.res.Resources
import android.graphics.Rect
import android.os.Build
import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import android.widget.ImageView
import androidx.core.content.edit
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import androidx.core.view.isGone
import androidx.core.view.isVisible
import helium314.keyboard.keyboard.KeyboardSwitcher
Expand All @@ -27,6 +30,16 @@ object FloatingKeyboardUtils {
fun setFloating(view: View?) {
val lp = view?.layoutParams as? ViewGroup.MarginLayoutParams ?: return
view.getWindowVisibleDisplayFrame(windowFrame)
// Android 15+ enforces edge-to-edge, so the IME window draws behind the navigation bar and the
// visible frame still spans behind it; the bottom drag/resize handles would otherwise end up
// under the nav bar. Subtract the window's nav bar inset to keep them reachable. Older versions
// keep the IME above the nav bar, so no adjustment is needed there (and applying it could
// subtract the nav bar height a second time and lift the keyboard off the bottom).
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) {
val navBarBottom = ViewCompat.getRootWindowInsets(view)
?.getInsets(WindowInsetsCompat.Type.navigationBars())?.bottom ?: 0
windowFrame.bottom -= navBarBottom
}
extraHeight = getSuggestionStripHeight(view.resources) + getFloatingHandleHeight(view.resources)
val (x, y) = readPosition(
view.context,
Expand Down