[ENG-1632] Audio turns in realtime session view#3734
Merged
connortbot merged 6 commits intomainfrom May 12, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
📝 Documentation updates detected! You can review documentation updates here |
Summary
|
chitalian
reviewed
May 11, 2025
chitalian
reviewed
May 11, 2025
| const timeA = a.timestamp ? new Date(a.timestamp).getTime() : 0; | ||
| const timeB = b.timestamp ? new Date(b.timestamp).getTime() : 0; | ||
| return timeA - timeB; | ||
| return ( |
chitalian
approved these changes
May 11, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR implements comprehensive audio turn tracking in the realtime session view by adding event lifecycle tracking and improving audio buffer handling across the codebase.
- Added new Message fields
trigger_event_idandending_event_idacross multiple type definitions to explicitly track audio message lifecycles - Implemented new 'response.audio.combined' message type and refactored audio buffer combination logic into a reusable function
- Updated timestamp sorting to prioritize
start_timestampwith fallback totimestampfor more accurate event sequencing - Added UI element in Realtime component showing event ID flow with
->arrows for clearer visualization - Removed 1ms gap requirement between steps and improved path generation for different message types
21 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the way I chose start and ending events for different types was a little arbitrary, so we should make it clear the start and end events in the UI [DONE]