[ENG-1607] Add Session Tag + Filtering by hcharlie1201 · Pull Request #3735 · Helicone/helicone

hcharlie1201 · 2025-05-10T20:44:10Z

Have special filters when column is "tag" then we apply a where filter to only the ids that have the tags in it (open to suggestion of just looking for tags and table name)
Fixed added new copy function
Have a new table in Clickhouse for tags
run a subquery
small refactors by replacing the thumbs up with tags (request by QAWolf)

Notion:

https://www.notion.so/helicone/Filter-With-Tags-1eec78c0f25e80ef9bc7e874530ed8ff?pvs=4

Frontend:

https://github.com/Helicone/helicone/pull/3745/files

Note

Currently in session view tables they don't see the tags as a column yet. Is they ask, then maybe we can provide, because currently I think we might have to do a join which is expensive.

Steps:

Once pr looks good and test, ill separate out into backend and frontend and merge backend + deploy first

vercel · 2025-05-10T20:44:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
helicone	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2025 1:48am
helicone-bifrost	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2025 1:48am
helicone-eu	🛑 Canceled (Inspect)			May 13, 2025 1:48am

promptless · 2025-05-10T20:45:43Z

📝 Documentation updates detected! You can review documentation updates here

fumedev · 2025-05-10T20:50:20Z

Summary

Introduces a new filtering mechanism for sessions based on tags in the database.
Adds endpoints to get and update session tags in the API.
Creates a new "tags" table in Clickhouse to store session tags.
Implements a subquery to filter sessions by tag.
Includes minor refactors and improvements to existing code.
Frontend updates include a new component for editing session tags.

chitalian · 2025-05-11T05:05:29Z

packages/copy-packages.sh

Thanks for fixing this

chitalian · 2025-05-11T05:07:11Z

clickhouse/migrations/schema_46_tags.sql

@@ -0,0 +1,10 @@
+CREATE TABLE IF NOT EXISTS default.tags (


I think we should add organization id here as the highest order on the cardinality to help the queries be faster. Also to check auth faster in the SessionManager

chitalian · 2025-05-11T05:07:35Z

valhalla/jawn/src/managers/SessionManager.ts

+
+  async getSessionTag(
+    sessionId: string
+  ): Promise<Result<string | null, string>> {


there is no auth checks here

own clarification: org check

chitalian · 2025-05-11T05:22:06Z

web/components/templates/feedback/sessionTag.tsx

+  const [formTag, setFormTag] = useState(getTag(id, type) || "");
+  const { setNotification } = useNotification();
+  const [open, setOpen] = useState(false);
+  useEffect(() => {


I know this is the way zustand recommends to do it, but i feel like there has to be a better way LOL

added a helper function to set it instead :D. Also better typing here

chitalian · 2025-05-11T05:28:29Z

web/lib/sessions/helpers.ts

nice job. Less code >>>

chitalian · 2025-05-11T05:28:52Z

web/filterAST/filterUIDefinitions/staticDefinitions.ts

dope you got the filterd to work

chitalian · 2025-05-11T05:31:19Z

valhalla/jawn/src/lib/shared/filters/filters.ts

+      continue;
+    }
+
+    switch (true) {


nit, switches in typescript are not like Elixr or Rust.

They SUCK.

Rust match statements >>>>

but in typescript it kind of annoying.

If you wanna use a switch, I ask that you move it to a helper function and use returns so we can remove all breaks

chitalian · 2025-05-11T05:31:40Z

valhalla/jawn/src/lib/shared/filters/filters.ts

  }),
  sessions_request_response_rmt:
-    easyKeyMappings<"sessions_request_response_rmt">({}),
+    easyKeyMappings<"sessions_request_response_rmt">({


dope you figured it out!

greptile-apps

PR Summary

This PR implements a comprehensive session tagging system to replace the existing thumbs up/down feedback mechanism, with support for both UI management and backend filtering capabilities.

New ClickHouse tags table added in schema_46_tags.sql using ReplacingMergeTree for deduplicating tagged entities
Introduced SessionTag component in web/components/templates/feedback/sessionTag.tsx with modal interface and state management via useTagStore
Changed latency calculation in web/lib/sessions/helpers.ts from time-span to cumulative trace latency
Added special tag filtering in valhalla/jawn/src/lib/shared/filters/filters.ts using subqueries to filter sessions by tag values
Expanded copy-packages.sh to copy entire common directory instead of just auth/server for better package sharing

_{26 file(s) reviewed, 9 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

valhalla/jawn/src/lib/db/ClickhouseWrapper.ts

valhalla/jawn/src/managers/SessionManager.ts

web/components/templates/feedback/sessionTag.tsx

web/components/templates/sessions/sessionId/Timeline/SessionTimelineTable.tsx

web/filterAST/filterUIDefinitions/staticDefinitions.ts

web/lib/sessions/helpers.ts

web/packages/common/sessions/tags.ts

web/store/features/sessions/tag.ts

chitalian · 2025-05-12T23:50:49Z

clickhouse/migrations/schema_46_tags.sql

+    entity_id String,
+    tag String,
+    created_at DateTime DEFAULT now(),
+    PRIMARY KEY (organization_id, entity_type, entity_id, tag)


Suggested change

PRIMARY KEY (organization_id, entity_type, entity_id, tag)

PRIMARY KEY (organization_id, entity_type)

Primary keys are weird in clickhouse.

We want to have it as the highest order granuale that is ~8k rows

This will be sufficient

Actually do we need primary key here? Since we're technically filtering on everything?

vercel bot deployed to Preview – helicone-bifrost May 10, 2025 20:44 View deployment

hcharlie1201 requested review from chitalian, connortbot and kavinvalli May 10, 2025 20:45

vercel bot deployed to Preview – helicone May 10, 2025 20:45 View deployment

vercel bot deployed to Preview – helicone-eu May 10, 2025 20:48 View deployment

chitalian requested changes May 11, 2025

View reviewed changes

greptile-apps bot reviewed May 11, 2025

View reviewed changes

vercel bot deployed to Preview – helicone-bifrost May 12, 2025 21:29 View deployment

vercel bot deployed to Preview – helicone-eu May 12, 2025 21:30 View deployment

hcharlie1201 force-pushed the charlie/eng-1620 branch from d64ad7e to 3ce2a30 Compare May 12, 2025 21:31

vercel bot deployed to Preview – helicone-bifrost May 12, 2025 21:35 View deployment

hcharlie1201 requested a review from chitalian May 12, 2025 21:40

vercel bot deployed to Preview – helicone-eu May 12, 2025 21:40 View deployment

vercel bot deployed to Preview – helicone May 12, 2025 21:44 View deployment

hcharlie1201 changed the title ~~[ENG-1620] Add Session Tag + Filtering~~ [ENG-1607] Add Session Tag + Filtering May 12, 2025

chitalian reviewed May 12, 2025

View reviewed changes

vercel bot deployed to Preview – helicone May 13, 2025 01:25 View deployment

vercel bot deployed to Preview – helicone-bifrost May 13, 2025 01:25 View deployment

vercel bot deployed to Preview – helicone-eu May 13, 2025 01:28 View deployment

hcharlie1201 force-pushed the charlie/eng-1620 branch from 49f733f to 10108fa Compare May 13, 2025 01:33

[ENG-1607] Filter + Tag Backend

04ab277

hcharlie1201 force-pushed the charlie/eng-1620 branch from 10108fa to 04ab277 Compare May 13, 2025 01:36

vercel bot deployed to Preview – helicone-bifrost May 13, 2025 01:41 View deployment

vercel bot deployed to Preview – helicone-eu May 13, 2025 01:42 View deployment

hcharlie1201 requested a review from chitalian May 13, 2025 01:44

vercel bot deployed to Preview – helicone May 13, 2025 01:48 View deployment

chitalian merged commit 502dea2 into main May 13, 2025
6 of 9 checks passed

chitalian deleted the charlie/eng-1620 branch May 13, 2025 23:34

	PRIMARY KEY (organization_id, entity_type, entity_id, tag)
	PRIMARY KEY (organization_id, entity_type)

Conversation

hcharlie1201 commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Uh oh!

vercel bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promptless bot commented May 10, 2025

Uh oh!

fumedev bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hcharlie1201 commented May 10, 2025 •

edited

Loading

vercel bot commented May 10, 2025 •

edited

Loading

fumedev bot commented May 10, 2025 •

edited

Loading