Skip to content

[ENG-1625] Only sticky request info on scroll #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortbot merged 1 commit into from
May 13, 2025
Merged

[ENG-1625] Only sticky request info on scroll #3738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 27 additions & 25 deletions web/components/templates/requests/RequestDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,30 +555,32 @@ export default function RequestDrawer(props: RequestDivProps) {
))}
</div>
</div>
</div>
)}
</header>

{/* Request Parameters */}
{requestDetails.parameterInfo.length > 0 && (
<div className="w-full flex flex-col gap-2 pt-4 border-t border-border px-4">
{requestDetails.parameterInfo.map((item) => (
<div
key={item.label}
className="grid grid-cols-[auto,1fr] gap-x-4 items-start"
>
<XSmall className="text-muted-foreground text-nowrap">
{item.label}
</XSmall>
<XSmall className="truncate min-w-0 text-right">
{item.value}
</XSmall>
</div>
))}
<div className="h-full w-full overflow-auto">
{/* Request Parameters - Moved out of header */}
{showDetails && requestDetails.parameterInfo.length > 0 && (
<div className="w-full flex flex-col gap-2 px-4 py-3 bg-card border-b border-border">
{requestDetails.parameterInfo.map((item) => (
<div
key={item.label}
className="grid grid-cols-[auto,1fr] gap-x-4 items-start"
>
<XSmall className="text-muted-foreground text-nowrap">
{item.label}
</XSmall>
<XSmall className="truncate min-w-0 text-right">
{item.value}
</XSmall>
</div>
)}
))}
</div>
)}

{/* Properties and Scores */}
<div className="w-full flex flex-col divide-y divide-border">
<div className="w-full flex flex-col divide-y divide-border bg-card border-b border-border">
{/* Properties */}
<ScrollableBadges
className="px-4"
Expand Down Expand Up @@ -613,14 +615,14 @@ export default function RequestDrawer(props: RequestDivProps) {
}}
/>
</div>
</header>

<div className="p-4 h-full w-full overflow-auto bg-card">
{/* Mapped Request */}
<RenderMappedRequest
mappedRequest={request}
onRequestSelect={onRequestSelect}
/>
{/* Main Content */}
<div className="p-4 bg-card">
<RenderMappedRequest
mappedRequest={request}
onRequestSelect={onRequestSelect}
/>
</div>
</div>

{/* Footer */}
Expand Down
Loading