Conversation
This reverts commit 0e481d6.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR reverts a previously implemented tier-based tagging feature for S3 storage operations across the Helicone logging system. The revert removes tier functionality from three key files: LoggingHandler.ts, s3Client.ts, and completely deletes tiers.ts.
The original feature added the ability to tag S3 objects with tier information (like 'pro', 'enterprise', etc.) for organizational and potentially billing purposes. The normalizeTier function in tiers.ts was designed to extract base tier names from complex tier strings (e.g., 'pro-variant' → 'pro'). The tier information was being passed through the entire upload pipeline, from the logging handler down to the S3 client methods, where it was applied as object metadata/tags.
This revert simplifies the S3 storage workflow by removing all tier-related parameters, method signatures, and tagging logic. The logging handler no longer extracts or passes tier information, and the S3 client methods have been simplified to their original form without tagging capabilities. This affects how S3 objects are organized and may impact any downstream processes that were relying on tier-based object categorization.
Confidence score: 1/5
- This PR has critical bugs that will cause runtime failures and should not be merged
- Score reflects incomplete revert that leaves broken code - the
storemethod still references undefinedtagsparameter - Pay close attention to
valhalla/jawn/src/lib/shared/db/s3Client.tslines 310 whereMetadata: tagswill fail
3 files reviewed, 1 comment
| } | ||
|
|
||
| command = new PutObjectCommand(commandOptions); | ||
| Metadata: tags, |
There was a problem hiding this comment.
logic: Critical bug: tags parameter may be undefined here since calling methods no longer pass it, but it's still being used in Metadata
| Metadata: tags, | |
| Metadata: tags || {}, |
There was a problem hiding this comment.
this is just what it was before i'd changed anything so its fine, https://github.com/Helicone/helicone/blob/21b649fdb1465d3b766e9b3ff851242f2cfd6a7b/valhalla/jawn/src/lib/shared/db/s3Client.ts
i also tested locally and this still logs fine (and made sure it was going into this else)
2 participants
This reverts commit 0e481d6.