Skip to content

fix: hql minimap coloring#4734

Merged
devinat1 merged 1 commit intomainfrom
devin/eng-3084-minimap
Sep 11, 2025
Merged

fix: hql minimap coloring#4734
devinat1 merged 1 commit intomainfrom
devin/eng-3084-minimap

Conversation

@devinat1
Copy link
Contributor

  • Added custom minimap color settings (background and slider colors for normal, hover, and active states) to the custom-dark theme.
  • Added custom minimap color settings (background and slider colors for normal, hover, and active states) to the custom-light theme.
  • Updated the Editor component to use the new custom-dark and custom-light themes instead of the default vs-dark and vs themes.

@vercel
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
helicone Building Building Preview Comment Sep 11, 2025 9:39pm
helicone-eu Building Building Preview Comment Sep 11, 2025 9:39pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
helicone-bifrost Skipped Skipped Sep 11, 2025 9:39pm

@claude
Copy link
Contributor

claude bot commented Sep 11, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR implements custom minimap theming for the Monaco Editor in Helicone's HQL (Helicone Query Language) page. The changes define two new custom themes - custom-dark and custom-light - that inherit from Monaco's base themes (vs-dark and vs respectively) but override specific minimap color properties.

The implementation adds color configurations for:

  • Minimap background color
  • Minimap slider colors for normal, hover, and active states

Both themes maintain a transparent editor background (#00000000) to blend seamlessly with the application's existing UI, while the minimap receives custom colors that align with Helicone's design system. The Editor component is updated to use these new custom themes instead of the default Monaco themes, ensuring the minimap visual appearance matches the overall application theming when users switch between dark and light modes.

This change integrates well with the existing theme switching infrastructure in the HQL page, leveraging the currentTheme state to dynamically apply the appropriate custom theme.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects simple theming changes with no business logic modifications and proper theme inheritance
  • No files require special attention

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@devinat1 devinat1 merged commit 71911cf into main Sep 11, 2025
8 of 11 checks passed
@devinat1 devinat1 deleted the devin/eng-3084-minimap branch September 11, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants