fix: make worker tests more reliable and skip on unrelated PRs#5534
fix: make worker tests more reliable and skip on unrelated PRs#5534
Conversation
- Add path filters to PR trigger so worker tests only run when worker/packages code changes (not on unrelated PRs) - Add singleWorker: true to avoid isolated storage conflicts with Durable Objects in parallel test execution - Increase testTimeout to 30s for Durable Object tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Claude finished @chitalian's task —— View job PR Review Complete ✅Reviewing PR #5534: "fix: make worker tests more reliable and skip on unrelated PRs" Todo List:
Score: 9/10 - Excellent improvements with minor optimization suggestionsThis PR makes solid improvements to test reliability and CI efficiency. The changes are well-targeted and address real issues with worker test execution. Suggestions Summary:
Detailed ReviewWorkflow Changes (.github/workflows/worker-test.yml:8-18)✅ Excellent addition - Adding path filters to both
Suggestion: Consider adding artifact retention for test outputs to help with debugging failures: - name: Upload test results
if: failure()
uses: actions/upload-artifact@v4
with:
name: worker-test-results
path: worker/test-results/
retention-days: 7Vitest Configuration (worker/test/ai-gateway/vitest.config.mts:6,9)✅ singleWorker: true (line 9) - This is a crucial fix for Durable Object tests:
✅ testTimeout: 30000 (line 6) - Increasing timeout to 30 seconds is reasonable:
Configuration QualityThe vitest configuration is well-structured with:
Minor Optimizations
Security & Best Practices
The changes are focused, well-reasoned, and directly address the stated problems. Great work on improving test reliability while optimizing CI resource usage! |
Ticket
Link to the ticket(s) this pull request addresses.
Component/Service
What part of Helicone does this affect?
Type of Change
Deployment Notes
Screenshots / Demos
Extra Notes
Any additional context, considerations, or notes for reviewers.
Context
Why are you making this change?
Screenshots / Demos