security: fix listener removal bug in WebsocketListeners#5562
Open
kolega-ai-dev wants to merge 1 commit intoHelicone:mainfrom
Open
security: fix listener removal bug in WebsocketListeners#5562kolega-ai-dev wants to merge 1 commit intoHelicone:mainfrom
kolega-ai-dev wants to merge 1 commit intoHelicone:mainfrom
Conversation
The removeListener method called filter() but discarded the result, since Array.filter() returns a new array. This left closed WebSocket connections in memory indefinitely, enabling memory exhaustion via repeated connect/disconnect cycles. The filtered result is now assigned back to the Map.
|
@FaizanKolega is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
@FaizanKolega is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
2 similar comments
|
@FaizanKolega is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
|
@FaizanKolega is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability identified and fix provided by Kolega.dev
Ticket
Security finding: Listener Removal Bug in WebsocketListeners
Component/Service
Type of Change
Deployment Notes
Context
The
removeListenermethod inWebsocketListeners.ts(line 77) callsArray.filter()but discards the returned array —filter()returns a new array and the original array in theMapis never updated. This means WebSocket listeners are never actually removed when connections close.Security implications:
ConnectedRouterStateobjects containingAuthParamspersist in memory after the connection is closed.Fix Applied
Assigned the filtered result back to the Map using
this.listeners.set(), matching the existing pattern already used inaddListener(line 59). When theorganizationIdhas no existing listeners, defaults to an empty array via the?? []fallback.Tests/Linters Ran
npx tsc --noEmit): Passed with no errorsnpx jest --detectOpenHandles): Pre-existing failures unrelated to this change (emoji sanitization tests). Confirmed the same failures exist onmain— test results are not affected by this fix.Contribution Notes
Following the Contributing Guidelines: branched from
main, code lints, change is minimal and focused on the security fix only.Extra Notes
Single-line logical fix. The
filter()call was already correct in its predicate — only the assignment of the result was missing.