security: use parameterized queries for ClickHouse model usage stats#5587
Merged
chitalian merged 1 commit intoHelicone:mainfrom Feb 19, 2026
Merged
Conversation
|
@ink-the-squid is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SQL injection vulnerabilities in
ModelUsageStatsManager.tsby replacing string interpolation with ClickHouse parameterized queries ({val_N:String}placeholders).This is the same class of vulnerability that was fixed in PR #5563 for
ModelComparisonManager.ts.Vulnerable Locations Fixed
getModelUsage()— model names from a prior query result were string-interpolated intoINclauses via`'${r.model}'`template literalsgetProviderUsage()— provider names from a prior query result were string-interpolated intoINclauses via`'${r.provider}'`template literalsgetProviderStats()— both theproviderpath parameter (using manualreplace(/'/g, "''")escaping) and model names from prior results were interpolated into queriesgetModelStats()— themodelpath parameter used manualreplace(/'/g, "''")escaping instead of parameterized queriesChanges
buildInClauseParams()helper method (mirrorsbuildModelNameParamsfrom ModelComparisonManager) that generates parameterized placeholders and params arraysdbQueryparameter array instead of string interpolationTesting
npx tsc --noEmit)