security: fix remaining HIGH findings (H2 remaining, H8, H10)#5600
Merged
chitalian merged 1 commit intoHelicone:mainfrom Feb 21, 2026
Merged
security: fix remaining HIGH findings (H2 remaining, H8, H10)#5600chitalian merged 1 commit intoHelicone:mainfrom
chitalian merged 1 commit intoHelicone:mainfrom
Conversation
H2 (remaining): Validate/clamp LIMIT and OFFSET as safe integers in
adminController, MetricsManager, and HeliconeDatasetManager.
H8: Remove query parameters from error log statements in
dbExecute, ClickhouseWrapper (jawn + worker), and valhalla.
Prevents PII/secrets from leaking into logs.
H10: Replace blanket /v1/public/* auth bypass with explicit
whitelist of known public route prefixes. Prevents accidental
exposure of new endpoints added under /v1/public/.
|
@ink-the-squid is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fixes — Batch 3
H2 (remaining): LIMIT/OFFSET SQL injection hardening
Files: adminController, MetricsManager, HeliconeDatasetManager
limitandoffsetas safe integers before SQL interpolationMath.floor()+Math.max()/Math.min()boundsH8: Remove query parameters from error logs
Files: dbExecute.ts, ClickhouseWrapper.ts (jawn + worker), valhalla.ts
parametersfromconsole.error()calls in catch blocksH10: Replace blanket public route auth bypass with whitelist
File:
valhalla/jawn/src/middleware/auth.tsreq.path.startsWith('/v1/public')to explicit whitelist of 8 known public route prefixes/v1/public/from being unauthenticatedAll TypeScript compiles clean (only pre-existing Gemini duplicate import errors on main).