test: add coverage for GridGenerator.ring and .spiral#123
test: add coverage for GridGenerator.ring and .spiral#123dusan-maintains wants to merge 1 commit into
Conversation
StantonMatt
left a comment
There was a problem hiding this comment.
Checked this locally on Node v22.22.2 / npm 10.9.7.
The targeted command from the PR passes:
npx jest test/src/GridGenerator.test.tsx --runInBandResult: 9/9 GridGenerator tests passed, including the new ring and spiral coverage.
I also ran the full suite:
CI=1 npm test -- --runInBandResult: 7 suites passed, 36 tests passed, 1 skipped, 9 snapshots passed.
The remaining skipped test is Hexagon should render correctly with default props in test/src/Hexagon/Hexagon.test.tsx, so it is separate from the old commented-out GridGenerator ring/spiral placeholder that this PR replaces. No PR checks are currently configured/running, so local verification is the evidence here.
|
I checked this PR locally. Validation:
Results: targeted GridGenerator tests passed, full Jest suite passed (7 suites, 36 passed, 1 skipped), TypeScript passed, and the diff check is clean. The PR is test-only and adds useful coverage for |
Summary
GridGenerator.ring()andGridGenerator.spiral().Why
Test Plan
npx jest test/src/GridGenerator.test.tsx --runInBandNotes