Add Menu Refresh Task and Command for Complete Menu Rebuilding #189
+203
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to give this a light ping! Let me know if there's any feedback you'd like me to address! Appreciate your time. |
BlitzOffline
previously approved these changes
Apr 25, 2025
|
Very nice feature, I just tested it. Thanks for your contribution to DeluxeMenus, @BitByLogics 💖 |
|
This will be ready to be merged in the coming days, if you could resolve the conflicts that would be greatly appreciated |
…ements # Conflicts: # src/main/java/com/extendedclip/deluxemenus/command/DeluxeMenusCommand.java # src/main/java/com/extendedclip/deluxemenus/utils/Messages.java
BlitzOffline
previously approved these changes
May 31, 2025
…mand imports with a wildcard, and add missing RefreshCommand import
BlitzOffline
approved these changes
Jun 1, 2025
Euphillya
added a commit
to Euphillya/DeluxeMenus-Folia
that referenced
this pull request
Jul 11, 2025
HelpChat@a465d9a Fix light_level being overwritten for LIGHT item. (HelpChat#200) HelpChat@41b2476 Fix MMO-Items not working when item id contains colon(s). (HelpChat#194) HelpChat@87141c0 Improve metadata / PDC usage (HelpChat#183) HelpChat@bc699b8 improve bstats (HelpChat#202) HelpChat@a20c30d update adventure for 1.21.5 (HelpChat#201) HelpChat@f048028 Fix exception that occurs when trying to add metadata. (HelpChat#205) HelpChat@08fbb34 fix command event action (HelpChat#206) HelpChat@d512986 Added support for the new CustomModelDataComponent (HelpChat#195) HelpChat@4f05d70 Finally, a release (HelpChat#207) HelpChat@9fc732f Moved to 1.14.2-dev and added CODE_OF_CONDUCT.md & CONTRIBUTING.md files (HelpChat#212) HelpChat@6775b7f Add Menu Refresh Task and Command for Complete Menu Rebuilding (HelpChat#189) HelpChat@4ae3bf6 fix README.md link (HelpChat#214) HelpChat@d884d8d Add gitbook badge (HelpChat#215) HelpChat@944a113 Add [log] Action to Output Console Messages for Debugging/Testing, Closes HelpChat#199 (HelpChat#208) HelpChat@94d6632 fix for textures not showing on player name heads (HelpChat#213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a refresh task that enhances dynamic menu management beyond the existing placeholder task. While the placeholder task only updates item names and lore, the refresh task calls the
refreshMenumethod, enabling comprehensive menu updates including:This functionality was implemented as a separate task because it rebuilds the entire menu, which would be inappropriate to include in the update task that focuses on lightweight item modifications.
Menus must explicitly opt-in to this functionality by setting
refresh: truein their configuration. The refresh interval is configurable via therefresh_intervalsetting, which specifies the frequency of refresh operations in seconds.Additionally, this PR adds a
/dm refresh <menu> [-s]command, allowing external plugins to trigger menu refreshes for all players with the specified menu open. The optional-sflag suppresses console feedback messages.