Skip to content

Fix exception that occurs when trying to add metadata. #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix exception that occurs when trying to add metadata. #205

wants to merge 3 commits into from

Conversation

DxsSucuk
Copy link

This PR fixes a class cast exception that occurs when trying to add INTEGER or LONG meta.

BlitzOffline
BlitzOffline requested changes May 27, 2025
View reviewed changes
Copy link
Member

@BlitzOffline BlitzOffline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I was unaware that this would throw. I did left an improvement comment.

We should also apply this fix to subtractMetaValue.

@DxsSucuk
Copy link
Author

Improve the code and implemented the fix for subtraction.

@DxsSucuk
Copy link
Author

I haven't tested the substraction part, but retested the adding code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlitzOffline BlitzOffline BlitzOffline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DxsSucuk @BlitzOffline