Skip to content

Improve exception handling when adding artifacts#1

Open
HendrikHuebner wants to merge 7 commits intomasterfrom
improve-add-artifact-exceptions
Open

Improve exception handling when adding artifacts#1
HendrikHuebner wants to merge 7 commits intomasterfrom
improve-add-artifact-exceptions

Conversation

@HendrikHuebner
Copy link
Owner

What changes were proposed in this pull request?

When multiple artifacts are added at once and one of them fails due to an exception (e.g. artifact already exists), the remaining artifacts should still be added instead of returning the error to the client immediately.

How was this patch tested?

Unit test and local testing.

This PR introduces the following user-facing changes

This section is for API auditing review.

AFFECTED VERSIONS:

PROBLEM DESCRIPTION:

Warmfix

  • Your change is a backport targeting at least one maintenance release. You must get your Shiproom Lead's approval for backporting this change. In case your Shiproom is unable to review and you are blocked, please review your backporting changes with Amit Shukla. Please choose the right category for your backporting change.
    • Critical fixes
    • UC critical adoption path
    • Logging changes (Debug, asserts, QPL/NQL)
    • Test or build infra changes
    • Other
  • Your PR is a backport making changes (add/remove/modify) to Spark Connect API. If so, please check the following action item:
    • Server-side API implementation is included in the backport. Not including server-side API implementation alongside proto changes has caused production bugs.
  • This PR should be warmfixed into DBR release branch(es)(e.g. dbr-branch-10.4) for next un-cut DBR maintenance release. Instructions
  • This PR should be considered for RC Warmfix for already cut but not shipped maintenance release. Instructions
  • This PR should be considered for RC Hotfix to the current production version. Instructions

Behavioral Change Information

Release Note Information

  • Change requires a release note (Behavioral changes require one). Please check the checkbox if this PR contains changes that should be mentioned in DBR release notes and if checked make sure a SC Jira ticket is in the PR title what will be used to document the release note.
  • Change does NOT require a release note

Products Affected

If your change is a behavioral change or needs a release note, which product lines are affected

  • All product lines
  • Classic DBR
  • Serverless Generic Compute
  • DBSQL
  • DLT

Security implications

This section is intended for the reviewers of this PR
Please, make sure you consider the content of "What are the responsibilities of code reviewers?" section of go/pr-security-review

@HendrikHuebner HendrikHuebner force-pushed the improve-add-artifact-exceptions branch 7 times, most recently from 60b8723 to adb42bf Compare August 20, 2025 09:06
@HendrikHuebner HendrikHuebner force-pushed the improve-add-artifact-exceptions branch from adb42bf to 5885ce0 Compare August 20, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant