Improve exception handling when adding artifacts#1
Open
HendrikHuebner wants to merge 7 commits intomasterfrom
Open
Improve exception handling when adding artifacts#1HendrikHuebner wants to merge 7 commits intomasterfrom
HendrikHuebner wants to merge 7 commits intomasterfrom
Conversation
60b8723 to
adb42bf
Compare
adb42bf to
5885ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When multiple artifacts are added at once and one of them fails due to an exception (e.g. artifact already exists), the remaining artifacts should still be added instead of returning the error to the client immediately.
How was this patch tested?
Unit test and local testing.
This PR introduces the following user-facing changes
This section is for API auditing review.
AFFECTED VERSIONS:
PROBLEM DESCRIPTION:
Warmfix
dbr-branch-10.4) for next un-cut DBR maintenance release. InstructionsBehavioral Change Information
Release Note Information
Products Affected
If your change is a behavioral change or needs a release note, which product lines are affected
Security implications
This section is intended for the reviewers of this PR
Please, make sure you consider the content of "What are the responsibilities of code reviewers?" section of go/pr-security-review