Open
Conversation
Owner
Author
|
I am fine with that @Hendrikto Edit 1: What do you think about replacing the conditional expression ( if (labs(value) >= 1 && labs(value) <= 100) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously (i.e commit 9a79e0d),
backlight_controlwould not validate thevalueargument and set unexpected brightness values.For example:
Sets the current brigthness to
0.Although Linux ensures the value set in
/sys/class/backlight/<backlight>/brightnessis between0andmax_brightness, I think it would be nice to notify the user of invalid arguments.Thanks for reading and I am open to feedback.