Fix/IcingaDBWeb: clean stale Icingaweb2 cookie only when Keycloak session is expired#1165
Merged
HenriWahl merged 3 commits intoJan 20, 2026
Conversation
Owner
|
Thanks @Plattenspatz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1163
In an IcingaDBWeb + Keycloak setup, Nagstamon can get stuck in a redirect-to-login loop when a persisted Icingaweb2 session cookie from an older run is reused after the Keycloak session already expired server-side.
This PR adds a minimal, server-type-specific cleanup for IcingaDBWeb:
Additionally, it guards _set_recheck() against missing HTML form elements to avoid a crash when authentication expired and the expected form cannot be found.