fix: check lane branch for .DONE after grace period expires - #274
Merged
Conversation
When a tmux session exits without the poll detecting .DONE on the filesystem, the engine now checks the lane git branch via 'git show <branch>:<path>/.DONE' before declaring failure. This handles the race condition where the worker completes all work, commits .DONE to the lane branch, and exits — but the worktree filesystem is stale or the poll timing barely misses the file. Previously this was the #1 cause of false task failures in production batches (seen in TP-065, TP-067, TP-072, TP-075, and user reports).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tmux session exits without the poll detecting .DONE on the
filesystem, the engine now checks the lane git branch via
'git show :/.DONE' before declaring failure.
This handles the race condition where the worker completes all work,
commits .DONE to the lane branch, and exits — but the worktree
filesystem is stale or the poll timing barely misses the file.
Previously this was the #1 cause of false task failures in production
batches (seen in TP-065, TP-067, TP-072, TP-075, and user reports).