fix(hold): no stale 'Lane held' alert when a ruling is already queued; prose ruling claims require affirmative language - #643
Open
HenryLach wants to merge 2 commits into
Open
Conversation
…; prose ruling claims require affirmative language Both from the first live exercise of the held state (penster 20260909T000015, two holds, both chains intact end to end): 1. The escalation reaches the supervisor live (mail recognition), so a fast ruling is often in the inbox before the worker exits. awaitHoldResolution published the held alert on entry and consumed the ruling one poll later — a stale-looking alert after the release. Peek once: if every open hold has a valid queued ruling, log 'Ruling already queued' and skip the publication. 2. isProseRulingClaim: 'hold(TP-1919): record HARD HOLD … pending operator ruling' is bookkeeping, not a claim. Claims must be affirmative (R###, verdict token, per/apply/implement/as-ruled language); pending/awaiting/ requesting/hold language is exempt unless a verdict token is present. The TP-2037 commit still flags. Tests: runner regression (queued ruling → release with no 'Lane held' alert), 11-case claim/bookkeeping matrix. 4118 pass.
…ruling claim (penster 20260911T234647 F)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both from the first live exercise of the held state (penster 20260909T000015,
two holds, both chains intact end to end):
The escalation reaches the supervisor live (mail recognition), so a fast
ruling is often in the inbox before the worker exits. awaitHoldResolution
published the held alert on entry and consumed the ruling one poll later —
a stale-looking alert after the release. Peek once: if every open hold has
a valid queued ruling, log 'Ruling already queued' and skip the publication.
isProseRulingClaim: 'hold(TP-1919): record HARD HOLD … pending operator
ruling' is bookkeeping, not a claim. Claims must be affirmative (R###,
verdict token, per/apply/implement/as-ruled language); pending/awaiting/
requesting/hold language is exempt unless a verdict token is present.
The TP-2037 commit still flags.
Tests: runner regression (queued ruling → release with no 'Lane held' alert),
11-case claim/bookkeeping matrix. 4118 pass.
Also covers penster 20260911T234647 field-report items B (stale
Lane heldalerts replayed after release, incl. the post-resumeEXPIREDone — the queued-ruling peek suppresses them) and theprose-claimhalf of F (ruling-independenthold-time vocabulary no longer flags).