fix(paths): handle Windows separators and absolute pointers on POSIX - #649
Open
cookerpapa wants to merge 1 commit into
Open
fix(paths): handle Windows separators and absolute pointers on POSIX#649cookerpapa wants to merge 1 commit into
cookerpapa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX path.resolve treats backslashes as filename characters. Normalizing afterward prefixes cwd and breaks task marker lookup. Native isAbsolute also misclassifies Windows drive-absolute pointer paths on POSIX.
Normalize task, repo, and worktree separators before resolving paths. Preserve external-task, cross-repo-copy, and archive lookup behavior. Validate pointer paths with Windows-aware absolute-path detection.
This fixes five existing Linux path-test failures found while validating #648. Adds marker fixtures and pointer coverage included in the Linux CI test selection.
Validation:
This branch is based directly on main. Its standalone full suite still encounters the existing template-loading assertion in project-config-loader.test.ts, reproduced on unmodified main and addressed separately by #648.