Fix SyGuS BV naming issue

[THinnerichs]

For SyGuS.BV there are some name clashes:

➜  HerbBenchmarks.jl git:(fix/sygus_BV_naming) ✗ grep -rnw data.jl -e 'Problem'

..
185018:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185077:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185145:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185168:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185200:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185232:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185265:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185288:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185335:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185378:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185499:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185537:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
185568:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
186592:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
186634:problem_PRE_icfp_gen_8 = Problem("problem_PRE_icfp_gen_8", [
186651:problem_PRE_icfp_gen_9 = Problem("problem_PRE_icfp_gen_9", [
186692:problem_PRE_icfp_gen_9 = Problem("problem_PRE_icfp_gen_9", [
186730:problem_PRE_icfp_gen_9 = Problem("problem_PRE_icfp_gen_9", [
186795:problem_PRE_icfp_gen_9 = Problem("problem_PRE_icfp_gen_9", [
186871:problem_PRE_icfp_gen_9 = Problem("problem_PRE_icfp_gen_9", [
186900:problem_PRE_icfp_gen_9 = Problem("problem_PRE_icfp_gen_9", [
...

I.e., there are many many name collisions, due to faulty parsing. The problem names are derived from the filenames:

-rw-r--r-- 1 thinnerichs thinnerichs 2.1K Oct 19  2023 PRE_icfp_gen_8.2.sl
-rw-r--r-- 1 thinnerichs thinnerichs 3.2K Oct 19  2023 PRE_icfp_gen_8.3.sl
-rw-r--r-- 1 thinnerichs thinnerichs 7.7K Oct 19  2023 PRE_icfp_gen_8.4.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.9K Oct 19  2023 PRE_icfp_gen_8.5.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.5K Oct 19  2023 PRE_icfp_gen_8.6.sl
-rw-r--r-- 1 thinnerichs thinnerichs  60K Oct 19  2023 PRE_icfp_gen_8.7.sl
-rw-r--r-- 1 thinnerichs thinnerichs 3.2K Oct 19  2023 PRE_icfp_gen_8.8.sl
-rw-r--r-- 1 thinnerichs thinnerichs 1.7K Oct 19  2023 PRE_icfp_gen_8.9.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.9K Oct 19  2023 PRE_icfp_gen_9.10.sl
-rw-r--r-- 1 thinnerichs thinnerichs 4.5K Oct 19  2023 PRE_icfp_gen_9.11.sl
-rw-r--r-- 1 thinnerichs thinnerichs 5.1K Oct 19  2023 PRE_icfp_gen_9.12.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.4K Oct 19  2023 PRE_icfp_gen_9.13.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.5K Oct 19  2023 PRE_icfp_gen_9.14.sl
-rw-r--r-- 1 thinnerichs thinnerichs 3.7K Oct 19  2023 PRE_icfp_gen_9.15.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.1K Oct 19  2023 PRE_icfp_gen_9.16.sl
-rw-r--r-- 1 thinnerichs thinnerichs 3.1K Oct 19  2023 PRE_icfp_gen_9.17.sl
-rw-r--r-- 1 thinnerichs thinnerichs 2.1K Oct 19  2023 PRE_icfp_gen_9.18.sl
-rw-r--r-- 1 thinnerichs thinnerichs 4.2K Oct 19  2023 PRE_icfp_gen_9.19.sl
-rw-r--r-- 1 thinnerichs thinnerichs 3.1K Oct 19  2023 PRE_icfp_gen_9.1.sl
...

But the numbers went missing.

I wrote a small script that

• finds duplicate problem names
• for each duplicate occurrence:
  • collects the hex constants from the IO examples
  • scans the original .sl files whose filename starts with the base name (e.g. PRE_icfp_gen_9)
  • picks the .sl file that contains >= 3 matching constants
  • renames the Julia problem to the correct stem (e.g. PRE_icfp_gen_9.16 -> PRE_icfp_gen_9_16)

This PR is the outcome of this:

186871:problem_PRE_icfp_gen_9_13 = Problem("problem_PRE_icfp_gen_9_13", [
186900:problem_PRE_icfp_gen_9_14 = Problem("problem_PRE_icfp_gen_9_14", [
186930:problem_PRE_icfp_gen_9_15 = Problem("problem_PRE_icfp_gen_9_15", [
186981:problem_PRE_icfp_gen_9_16 = Problem("problem_PRE_icfp_gen_9_16", [
187004:problem_PRE_icfp_gen_9_17 = Problem("problem_PRE_icfp_gen_9_17", [
187045:problem_PRE_icfp_gen_9_18 = Problem("problem_PRE_icfp_gen_9_18", [
187068:problem_PRE_icfp_gen_9_19 = Problem("problem_PRE_icfp_gen_9_19", [
187129:problem_PRE_icfp_gen_9_2 = Problem("problem_PRE_icfp_gen_9_2", [
187142:problem_PRE_icfp_gen_9_20 = Problem("problem_PRE_icfp_gen_9_20", [
187174:problem_PRE_icfp_gen_9_3 = Problem("problem_PRE_icfp_gen_9_3", [
187227:problem_PRE_icfp_gen_9_4 = Problem("problem_PRE_icfp_gen_9_4", [
187258:problem_PRE_icfp_gen_9_5 = Problem("problem_PRE_icfp_gen_9_5", [
187294:problem_PRE_icfp_gen_9_6 = Problem("problem_PRE_icfp_gen_9_6", [
187355:problem_PRE_icfp_gen_9_7 = Problem("problem_PRE_icfp_gen_9_7", [
187391:problem_PRE_icfp_gen_9_8 = Problem("problem_PRE_icfp_gen_9_8", [
187427:problem_PRE_icfp_gen_9_9 = Problem("problem_PRE_icfp_gen_9_9", [

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.47%. Comparing base (ddc9b76) to head (403a9c1).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   37.47%   37.47%           
=======================================
  Files          25       25           
  Lines         862      862           
=======================================
  Hits          323      323           
  Misses        539      539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ReubenJ]

Nice catch. Looks good