Adjust some nullpo checks#3378
Open
MrKeiKun wants to merge 2 commits into
Open
Conversation
…egen_pc. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
changed the title
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
force-pushed
the
fix-2973-nullpo-checks
branch
from
49350d4 to
f4dbee7
Compare
hemagx
requested changes
May 24, 2026
| nullpo_retv(regen->sitting); | ||
| nullpo_retv(regen->skill); | ||
|
|
||
| if (regen->skill == NULL) |
Contributor
There was a problem hiding this comment.
The original design here is that regen->skill, regen->sitting should never be null, but now you're defaulting to make it sd is there a rationale behind it? the commit messages doesn't give a rationale at all or explain how it fixes this issue, this seem more like a band-aid workaround than an actual fix for the issue mentioned.
| struct regen_data_sub *skill_regen = regen->skill; | ||
| skill_regen->hp = 0; | ||
| skill_regen->sp = 0; | ||
| if (regen->skill != NULL) { |
Contributor
There was a problem hiding this comment.
It cannot be null still with your check this is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Adjust some nullpo check on status_calc_regen_pc and status_calc_regen_rate_pc
Issues addressed:
#2973
#2847 (probably?)